Add support for launching phantomJS on OSX #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I probably have not tested this enough now that I think about it. I'm not sure what happens if Phantom isn't installed, for example. Will update whenever I get a chance. |
|
Hello and thank you for your pull request. Sadly, the core developer responsible for this project has changed. I took some of his projects under my wings, but not yet this one. We will try to manage this PR in some, however indefinite, time. I hope we will be able to look at that and other PRs in next two weeks. |
|
Hi, we finally know that unfortunately we'll not be able to maintain browser-launcher2 anymore. More details in: #57. There may be new active forks available, so you can port your PR to one of them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like support for phantomJS on OSX got lost in the shuffle somewhere along the line. This pull request re-adds support for it.