Added a setting to control which formats are ignored #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to beetbox#2688 where a list of hard-coded non-audio formats to ignore has been added. Some users may want to rip the audio portion of video tracks (e.g. DVD-Video) so it would be beneficial to let them control exactly which formats to ignore. I added a `ignored_formats` setting for that purpose and moved the hard-coded list into the config. Test and documentation have been updated accordingly. Aside: I also clarified the changelog a bit regarding this change and the related one for beetbox#1210.
|
Looking good! For consistency with the other current config options in the AFAICT, the Travis failures above seem to be spurious (just Travis flakiness): |
|
Sure makes sense, I like consistency too 😉 I just pushed another commit with the setting renamed. |
|
Looks perfect! Thank you again! ✨ |
|
No worries, thank you for Beets! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #2688 where a list of hard-coded non-audio formats to
ignore has been added. Some users may want to rip the audio portion of
video tracks (e.g. DVD-Video) so it would be beneficial to let them
control exactly which formats to ignore.
I added a
ignored_formatssetting for that purpose and moved thehard-coded list into the config. Test and documentation have been
updated accordingly.
Aside: I also clarified the changelog a bit regarding this change and
the related one for #1210.