-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't try to match non-audio media fetched from MusicBrainz #2688
Comments
Indeed! Let’s track this in #1210. |
I think that's actually a slightly different issue that may need separate consideration and re-opening. #1210 is about having a single (or multiple) non-music tracks inside a given medium, mixed with audio tracks. See track 21 on this - xml This issue is about skipping a complete medium, for release that have CD+DVD for example. See this - xml In the later case, the medium to skip is identified by its <medium-list count="2">
<medium>
<position>1</position>
<format id="9712d52a-4509-3d4b-a1a2-67c88c643e31">CD</format>
<track-list count="10" offset="0">...</track-list>
</medium>
<medium>
<position>2</position>
<format id="2875c583-4580-3a90-b723-ba1b39921e23">DVD</format>
<track-list offset="0" count="7">...</track-list>
</medium>
</medium-list> A list of formats is available here Currently when trying to import this release, I get:
|
Ah, I see! So they’re certainly related, but not exactly the same problem. Perhaps #2404 is a closer precedent? |
I think that's different too. #2404 is about alternative audio media, like a CD and a DVD-Audio, or a CD and a Digital Media. I think this issue is simpler, it's just about ignoring media that don't contain audio (such as DVD, or CD-Rom (data) disks). |
Got it; thanks for helping to clarify. I'll reopen this and change the title. |
Some releases have non-audio media, such as CD+DVD or CD+DVD-Video. Skip these media when fetching album info as they will never match audio tracks and will always report missing tracks. I took the naive approach of cherry-picking a list of media suspected to not contain audio from the [MusicBrainz formats list](https://musicbrainz.org/doc/Release/Format)
Some releases have non-audio media, such as CD+DVD or CD+DVD-Video. Skip these media when fetching album info as they will never match audio tracks and will always report missing tracks. I took the naive approach of cherry-picking a list of media suspected to not contain audio from the MusicBrainz formats list: https://musicbrainz.org/doc/Release/Format
Some releases have non-audio media, such as CD+DVD or CD+DVD-Video. Skip these media when fetching album info as they will never match audio tracks and will always report missing tracks. I took the naive approach of cherry-picking a list of media suspected to not contain audio from the MusicBrainz formats list: https://musicbrainz.org/doc/Release/Format
Some releases have non-audio media, such as CD+DVD or CD+DVD-Video. Skip these media when fetching album info as they will never match audio tracks and will always report missing tracks. I took the naive approach of cherry-picking a list of media suspected to not contain audio from the MusicBrainz formats list: https://musicbrainz.org/doc/Release/Format
Some releases have non-audio media, such as CD+DVD or CD+DVD-Video. Skip these media when fetching album info as they will never match audio tracks and will always report missing tracks. I took the naive approach of cherry-picking a list of media suspected to not contain audio from the MusicBrainz formats list: https://musicbrainz.org/doc/Release/Format
Fixes #2688: Skip non-audio media from MusicBrainz
What would be a good way to make this optional? Boolean flag in the config? Or perhaps making the list of formats configurable? |
Users may want to keep tracking video tracks, for example if they rip the audio part of the video tracks. Added a setting to allow this. This is related to the beetbox#2688 change. My impression is that it would be quite rare though so I made the setting ignore video tracks by default, but that's easily changed if desired.
This is related to beetbox#2688 where a list of hard-coded non-audio formats to ignore has been added. Some users may want to rip the audio portion of video tracks (e.g. DVD-Video) so it would be beneficial to let them control exactly which formats to ignore. I added a `ignored_formats` setting for that purpose and moved the hard-coded list into the config. Test and documentation have been updated accordingly. Aside: I also clarified the changelog a bit regarding this change and the related one for beetbox#1210.
This is related to beetbox#2688 where a list of hard-coded non-audio formats to ignore has been added. Some users may want to rip the audio portion of video tracks (e.g. DVD-Video) so it would be beneficial to let them control exactly which formats to ignore. I added a `ignored_formats` setting for that purpose and moved the hard-coded list into the config. Test and documentation have been updated accordingly. Aside: I also clarified the changelog a bit regarding this change and the related one for beetbox#1210.
Matching a folder containing all audio files of a MB release made of CD+DVD for instance fails since beets does take into account also the video files.
For instance (1 CD+ 1DVD):
https://musicbrainz.org/release/2775743e-2d9c-4b7f-9baa-1d24dc44c769
https://musicbrainz.org/release/f457c3e1-0d98-4904-9d9e-a085bc5b232b
I imagine the same happens for enhanced CDs with some additional video track.
In general I think the right thing to do is that all media files that are marked as video in MB should not be considered for matching. After all beets currently only deals with audio files.
The text was updated successfully, but these errors were encountered: