Allow repeated future outcomes in mocked gRPCs #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
mhidalgo-bdai
requested review from
jbarry-bdai,
heuristicus and
amessing-bdai
as code owners
|
Putting it out for you to try @jbarry-bdai. I'll add more tests and update the wiki later. |
amessing-bdai
approved these changes
Feb 26, 2024
jbarry-bdai
approved these changes
Feb 27, 2024
Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
|
OK, this is ready to go @amessing-bdai. |
amessing-bdai
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #81. This patch should make it easier to work with blocking calls that invoke many gRPCs.
Now, in addition to
future.returns()andfuture.fails(), you can invokefuture.returns().repeatedly(N)andfuture.fails().repeatedly(N)to repeat the same outcome a finite number of times andfuture.returns().forever()andfuture.fails().forever()to repeat the same outcome indefinitely.