-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spot_wrapper.testing
machinery
#81
Conversation
Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
8435ea8
to
a6d904f
Compare
LGTM. This is well written and I don't really see anything wrong with it. Only nit is that it'd be easier on reviewers to split up into multiple PRs next time due to length. |
Yeah. Sorry about that. It took a surprising amount of code just getting |
Quick question about the copyright notices in some of the files. This repo is under the MIT license. Is there a need for the additional notices? |
I've found both in the wild (i.e. everything has a notice vs. only the root LICENSE does). I usually default to putting the copyright notice everywhere, for best granularity (specially when many organizations start contributing to the same codebase), but I'm no lawyer and I don't mind either way. |
Good question. The
I am also not a lawyer. But this page has some good info. Based on what I read, I think the statement "All rights reserved" on each file is probably inappropriate in an MIT licensed project. But I like @mhidalgo-bdai's idea of finer granularity in a multi-organization project. (Although that will get muddied quickly as other organizations make modifications to existing files.) So I think I'd recommend putting something like this in each file:
Although the easiest thing for now is probably just to remove it. But let me ask around with more folks who may be more knowledgeable. |
I'm good with @baxelrod-bdai suggestion if you are @heuristicus @tervay-bdai. |
Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
Done in 65c608a |
Let's see what advice @baxelrod-bdai gets from more knowledgeable people, but looks good to me for now. |
Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
This PR introduces
pytest
compatible machinery to aid in testingspot_wrapper
,spot_ros2
, and beyond.