[SW-1658] Allow body frame to be root of TF tree

[khughes-bdai]

Change Overview

The goal of this PR is to allow the body frame to be the root of the tf tree, in case you want to broadcast your own custom odometry transform to "body". Currently that's not possible as body always has either odom or vision as a parent, and a tf frame cannot have more than two parents.

• adds new parameter tf_root to allow you to specify what frame will be the root of the TF tree.
  • If unset it will default to "odom", which is the current behavior on main
  • you can set tf_root to "vision" or "body" and pass this in via config file, and those frames will become the TF root as expected. (All the other frames and transforms still exist, it just changes the layout of the tree).
• Nothing about the odometry topic parent frame changes as the expectation is this should be handled by the preferred_odom_frame parameter. (athough it is worth noting that this can't actually be changed currently, as it is hardcoded to be "odom" in the launchfile...

  spot_ros2/spot_driver/launch/spot_driver.launch.py

  Line 109 in 941ab5e

  spot_robot_state_publisher_params = {"spot_name": spot_name, "preferred_odom_frame": "odom"}

  )
• deleted some dead python code dealing with preferred_odom_frame parameter, as this was adjacent to the parameter I added. (all of this is in C++ now).

Testing Done

• default behavior on robot unchanged
• tested new parameter set to "odom", "vision", "body" on robot and made sure TF tree matched expectations
• ensure object sync/ fiducials are still read as expected as some calls there changed
• updated unit tests pass

[khughes-bdai]

• [SW-1658] Allow body frame to be root of TF tree #536 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[coveralls]

Pull Request Test Coverage Report for Build 12377409593

Details

• 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
• 440 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.01%) to 51.184%

---

Files with Coverage Reduction	New Missed Lines	%
spot_ros2/spot_ros2/spot_driver/spot_driver/spot_ros2.py	440	44.44%

Totals
Change from base Build 12186201404:	-0.01%
Covered Lines:	1946
Relevant Lines:	3802

---

💛 - Coveralls

[mhidalgo-bdai]

LGTM

[khughes-bdai]

Merge activity

• Dec 18, 9:55 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Dec 18, 9:56 AM EST: A user merged this pull request with Graphite.