576 - Create and use loading label component and refactor #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
loneil
requested changes
Jul 18, 2023
There was a problem hiding this comment.
Other than comment about prop default/format it looks good to me, solution is pretty much what I had in mind for this. Tested locally (faked delay to see spinners).
Likely won't ever see these spinners much in real operations 😄 but it's a good thing to have if the connections ever load slowly (or slower than the main tables' datas)
Thanks again!
services/tenant-ui/frontend/src/components/common/LoadingLabel.vue
Outdated
Show resolved
Hide resolved
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Should be updated now. |
Thank you, merging to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is addressing issue 576 in the backlog. Thought I would pick up a smaller task for some practice.
Added a component that shows a spinner when a label is waiting to become defined. I'm not sure this would be visible very often because it would need to have the other stores loaded but not contacts. But anyway I think it looks decent and the component might be useful elsewhere.
I forced the contacts to delay loading for 3 seconds to see the effect.
Traction.Tenant.Console.webm
I refactored some code because the findByConnectionName function in the contacts store was only needed. Made it so if the contacts are loading findByConnectionName returns undefined type and if it can't find a match it returns a blank string (Maybe should should say not found or something other than blank ? Could be null but then would render blank anyway)
Wrote some tests and some mocks. Found a couple annoying things and added gotchas in the readme and some comments.
I like to use VS code organize imports and sort lines so some imports go mix around.