Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a loader on connection name instead of ... while contacts loading #576

Closed
loneil opened this issue May 9, 2023 · 1 comment
Closed

Show a loader on connection name instead of ... while contacts loading #576

loneil opened this issue May 9, 2023 · 1 comment
Assignees
@loneil
Labels
TenantUI Tickets related to the Tenant UI Vue/Node app

Comments

@loneil
Copy link
Collaborator

loneil commented May 9, 2023 •
edited by hiteshgh
Loading

The contactStore findConnectionName computed finds the mapped contact alias for an ID. It's reactive so it could return nothing while the contacts are loading. This currently shows ... on the UI if the contact is not shown yet/found.
Could have a different logic for not found vs loading ideally...

See comment here #549 (comment)

AC

  1. Display a loader on connection name instead of ... while contacts loading
@loneil loneil mentioned this issue May 9, 2023
Merged
@loneil loneil self-assigned this Jul 18, 2023
@loneil loneil added the TenantUI Tickets related to the Tenant UI Vue/Node app label Jul 18, 2023
@loneil
Copy link
Collaborator Author

loneil commented Jul 18, 2023

Assigning into current sprint to track review and comments from community contribution PR from @jamshale at PR #709

@loneil loneil closed this as completed Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loneil loneil

Labels
TenantUI Tickets related to the Tenant UI Vue/Node app
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@loneil