Feature/auto approve reservation #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
…s file Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
esune
force-pushed
the
feature/auto-approve-reservation
branch
from
2fa7da0
to
e37daa4
Compare
loneil
reviewed
May 18, 2023
services/tenant-ui/frontend/src/components/reservation/ReservationConfirmation.vue
Outdated
Show resolved
Hide resolved
loneil
reviewed
May 18, 2023
|
Pulled locally and ran with local Docker and works all good.
|
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Logged #592 to track this. I think it is fairly low priority though, given the edge use-case and the fact that there is a way to deal with it. |
|
Errors appear to be related to the PR being opened from a fork, rather than from a branch in the repository. Merging as the changes are required to continue working on bcgov/DITP-DevOps#74 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add setting to auto-approve tenant reservations - useful for situations such as described in #583.
UI was updated to show password as well - it could use some extra tweaks, potentially.
Resolves #584, #587