Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully-Automatic Tenant Registration Flow #584

Closed
esune opened this issue May 16, 2023 · 5 comments · Fixed by #588
Closed

Fully-Automatic Tenant Registration Flow #584

esune opened this issue May 16, 2023 · 5 comments · Fixed by #588
Assignees

Comments

@esune
Copy link
Member

esune commented May 16, 2023

For situations such as what is described here, it would be nice to have a fully-automatic tenant approval option that will not require the innkeeper to manually approve one by one each registration request.

Acceptance Criteria:
Add an environment variable to be set at deployment time that, if present and set to true, automatically approves the tenant registration request.

The tenant will still be responsible for completing the check-in step and obtaining the credentials to access/control their agent.

@esune esune self-assigned this May 16, 2023
@loneil
Copy link
Collaborator

loneil commented May 16, 2023

I think this would be (in the Innkeeper plugin):

  • User POSTs to /multitenancy/reservations as usual, the historical record and contact info would still be there
  • That service endpoint detects some auto-approve flag and actions the same service layer call that is currently actioned by /innkeeper/reservations/{reservation_id}/approve
  • The check-in password is returned back to the /multitenancy/reservations call, so in this case the body has that extra password.
  • User proceeds with check-in normally for next steps to provide the password and stuff to /multitenancy/reservations/{reservation_id}/check-in

If this were to be supported in the Tenant UI would just need some tweaks to detect if the password is returned in the reservation step and appropriate screen text.
And adjust the email text instructions and info as well.

@esune
Copy link
Member Author

esune commented May 17, 2023

I think we can just go with the regular check-in flow, just short-circuit the approval. The password is currently being sent out via email, isn't it? I'm looking at triggering the exact same code as the one that is executed when the approve endpoint is hit

@esune
Copy link
Member Author

esune commented May 17, 2023

On second thought, I think @loneil you're right: we will probably want to display the password on-screen for immediate use.

@loneil
Copy link
Collaborator

loneil commented May 17, 2023

I think we can just go with the regular check-in flow, just short-circuit the approval. The password is currently being sent out via email, isn't it? I'm looking at triggering the exact same code as the one that is executed when the approve endpoint is hit

Yeah exactly, that's the flow I mean in bullet point 2 above.

The password is just returned by the approve endpoint currently, so it would be returned by the 1st POST instead if this auto-flag is on.
Then the emailing is just the tenant-ui taking the password out of the result body and it's emailing, so no emails known by Traction or anything.

@loneil
Copy link
Collaborator

loneil commented May 24, 2023

Sorry was dragging my tickets around and picked up this one, not sure if this and #587 should be in done

@esune esune closed this as completed May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants