Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16858 Set Correction Filing Status as PENDING_CORRECTION #2109

Merged
merged 4 commits into from
Jun 29, 2023
Merged

16858 Set Correction Filing Status as PENDING_CORRECTION #2109

merged 4 commits into from
Jun 29, 2023

Conversation

kzdev420
Copy link
Collaborator

Issue #: /bcgov/entity#16858

Description of changes:

The conversion local correction will need to move to "PENDING_CORRECTION" status as well

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@kzdev420 kzdev420 requested review from Jxio and vysakh-menon-aot and removed request for Jxio June 28, 2023 23:26
@kzdev420 kzdev420 self-assigned this Jun 28, 2023
@kzdev420 kzdev420 requested a review from argush3 June 29, 2023 01:44
@argush3 argush3 removed the request for review from vysakh-menon June 29, 2023 01:47
@argush3
Copy link
Collaborator

argush3 commented Jun 29, 2023

@kzdev420 can we get a test added for this?

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #2109 (5ded7e1) into main (f1839af) will decrease coverage by 0.09%.
The diff coverage is 47.36%.

@@            Coverage Diff             @@
##             main    #2109      +/-   ##
==========================================
- Coverage   77.69%   77.60%   -0.09%     
==========================================
  Files         198      198              
  Lines       11368    11396      +28     
  Branches     1910     1916       +6     
==========================================
+ Hits         8832     8844      +12     
- Misses       1962     1978      +16     
  Partials      574      574              
Flag Coverage Δ
entityfiler 80.08% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
legal-api/src/legal_api/reports/report.py 26.90% <5.55%> (-0.62%) ⬇️
legal-api/src/legal_api/core/filing.py 86.45% <66.66%> (+0.19%) ⬆️
legal-api/src/legal_api/services/pdf_service.py 98.18% <80.00%> (-1.82%) ⬇️
legal-api/src/legal_api/version.py 100.00% <100.00%> (ø)
...r/src/entity_filer/filing_processors/alteration.py 92.30% <100.00%> (+0.30%) ⬆️
...r/src/entity_filer/filing_processors/correction.py 94.87% <100.00%> (+0.13%) ⬆️
...ocessors/filing_components/rules_and_memorandum.py 87.50% <100.00%> (ø)
...ue_services/entity-filer/src/entity_filer/utils.py 100.00% <100.00%> (ø)
..._services/entity-filer/src/entity_filer/version.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@kzdev420
Copy link
Collaborator Author

@kzdev420 can we get a test added for this?

Hi, @argush3. I added the test. Please review it

@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kzdev420 kzdev420 merged commit 5c6161e into bcgov:main Jun 29, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants