-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
16858 Set Correction Filing Status as PENDING_CORRECTION #2109
Merged
kzdev420
merged 4 commits into
bcgov:main
from
kzdev420:16858_file_correction_record_conversion
Jun 29, 2023
Merged
16858 Set Correction Filing Status as PENDING_CORRECTION #2109
kzdev420
merged 4 commits into
bcgov:main
from
kzdev420:16858_file_correction_record_conversion
Jun 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzdev420
requested review from
Jxio and
vysakh-menon-aot
and removed request for
Jxio
June 28, 2023 23:26
argush3
reviewed
Jun 29, 2023
queue_services/entity-filer/src/entity_filer/filing_processors/correction.py
Outdated
Show resolved
Hide resolved
@kzdev420 can we get a test added for this? |
Codecov Report
@@ Coverage Diff @@
## main #2109 +/- ##
==========================================
- Coverage 77.69% 77.60% -0.09%
==========================================
Files 198 198
Lines 11368 11396 +28
Branches 1910 1916 +6
==========================================
+ Hits 8832 8844 +12
- Misses 1962 1978 +16
Partials 574 574
Flags with carried forward coverage won't be shown. Click here to find out more.
|
argush3
reviewed
Jun 29, 2023
queue_services/entity-filer/tests/unit/test_worker/test_correction_conversion.py
Outdated
Show resolved
Hide resolved
argush3
approved these changes
Jun 29, 2023
vysakh-menon-aot
approved these changes
Jun 29, 2023
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#16858
Description of changes:
The conversion local correction will need to move to "PENDING_CORRECTION" status as well
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).