Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Business Schemas - Unable to File Corrections for Record Conversions. #16858

Closed
2 tasks
riyazuddinsyed opened this issue Jun 22, 2023 · 5 comments
Closed
2 tasks
Assignees
Labels
bug Something isn't working ENTITY Business Team good first issue Good for newcomers

Comments

@riyazuddinsyed
Copy link
Collaborator

riyazuddinsyed commented Jun 22, 2023

To Do List:

  • Modify the schema to allow local correction of the Conversion filing for firms.
    • also update unit tests
    • does anything (eg, Legal API) need to be rebuilt? yes, legal api will need to updated to use the new schema version after conversion is added as a valid correctedFilingType to the correction schema.
  • Update also the Filer as needed. Please reference filer notes in comment below.

Describe the bug in the current situation
When the staff tries to make a correction for Record Conversion then the UI throws an error.

Steps to reproduce the behavior:

  1. Go to 'https://test.business.bcregistry.gov.bc.ca/FM1104477/correction'
  2. Try to File the Correction for Record Conversion.
  3. See the error

Screenshots/ Visual Reference/ Source
Screen Shot 2023-06-22 at 2.05.58 PM.png

@riyazuddinsyed riyazuddinsyed added bug Something isn't working ENTITY Business Team labels Jun 22, 2023
@severinbeauvais severinbeauvais changed the title Unable to File Corrections for Record Conversions. Filings UI - Unable to File Corrections for Record Conversions. Jun 22, 2023
@severinbeauvais severinbeauvais self-assigned this Jun 23, 2023
@severinbeauvais
Copy link
Collaborator

@argush3 @vysakh-menon-aot This is a schema error -- the correction schema doesn't allow "conversion" as a Corrected Filing Type. Who can be assigned to fix this (assuming we CAN correct a firm conversion)?

@davemck513 This is not a new error.

@severinbeauvais severinbeauvais changed the title Filings UI - Unable to File Corrections for Record Conversions. Business Schemas - Unable to File Corrections for Record Conversions. Jun 23, 2023
@severinbeauvais severinbeauvais removed their assignment Jun 23, 2023
@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Jun 23, 2023

Options:

  1. change the schema to allow conversion corrections (and hope it works, or fix issues)
  2. change the UI to not allow corrections to conversion filings

cc: @Mihai-QuickSilverDev

@jdyck-fw jdyck-fw added the good first issue Good for newcomers label Jun 26, 2023
@Mihai-QuickSilverDev
Copy link
Collaborator

As discussed in the Entities daily scrum on June 26, 2023, and based on #15768, I have added a To Do list in the description of this ticket.
As a future improvement, the Correction of a firms Conversion filing would have to be moved to the full Correction framework.

@argush3
Copy link
Collaborator

argush3 commented Jun 26, 2023

Note that this will likely require an update to the filer as well.

Other local correction filings like COOP COA, CODs and ARs make it to the filer but only get moved to the "PENDING_CORRECTION" status. i.e. besides a status update, no actual data is corrected for the business by the filer.

The conversion local correction will need to move to "PENDING_CORRECTION" status as well. Existing local corrections reference code can be found here.

@kzdev420
Copy link
Collaborator

Hi

I am not able to merge business-schemas PR myself. - bcgov/business-schemas#139
If you guys look good, please approve and merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ENTITY Business Team good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants