QA fixes #74
Merged
QA fixes #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
=======================================
Coverage ? 87.21%
=======================================
Files ? 24
Lines ? 1197
Branches ? 59
=======================================
Hits ? 1044
Misses ? 96
Partials ? 57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-btr-dev--pr-74-9plsm4ih.web.app |
kialj876
force-pushed
the
18481-18664-qa-fixes
branch
from
beb8c20
to
7b52558
Compare
kialj876
commented
Dec 7, 2023
Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-btr-dev--pr-74-9plsm4ih.web.app |
hfekete
approved these changes
Dec 7, 2023
|
Nice ! |
patrickpeinanw
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue:*bcgov/entity#18481
*Issue:*bcgov/entity#18664
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).