Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Page Title (Significant Individual Change), Text, Change Date control, Add an Individual control #18481

Closed
17 tasks done
steveburtch opened this issue Nov 6, 2023 · 4 comments
Assignees
Labels
BTR Business Transparency Register Register BO

Comments

@steveburtch
Copy link

steveburtch commented Nov 6, 2023

Design Ticket:
https://app.zenhub.com/workspaces/design-team-space-6144b1bb15dbac0013e68828/issues/gh/bcgov/entity/17972

Add the following elements to the Significant Individual Change standalone page:

  • Page Title
  • Text (descriptive paragraph below page title)
  • Use date select from Birthdate (no date in future)
  • "Add an Individual" control (expand the form)

Details (from dev)

  • page title
  • text
  • filing date selection
    • effective date select
    • effective date set for filing
    • selected date propagated to all new sig individuals
    • formatting in line with 'add individual section'
    • alter filing store of dates to iso strings
    • display dates correctly in table
  • add individual button
    • 'add individual section' only appears after button press
    • button is not showing while add individual section is showing
    • update 'Done' button to collapse 'add individual section' and emit data
    • update page to add emitted data to filing
    • add 'Cancel' button in 'add individual section' to collapse and not add any data
  • add internationalization for all text
  • add tests
@gunanagar
Copy link
Collaborator

gunanagar commented Dec 5, 2023

@kialj876
Please check the below issue
QA- Issue - Placeholder text is not as per the design in "Significance individual change date "field

https://app.zenhub.com/workspaces/registries-benowner-644043015b6fa1002c69a9f4/issues/zh/155

@gunanagar gunanagar added bug Something isn't working and removed bug Something isn't working labels Dec 5, 2023
@gunanagar
Copy link
Collaborator

Tested.
Screen Shot 2023-12-08 at 10 21 05 AM

@forgeuxGH5
Copy link
Collaborator

forgeuxGH5 commented Dec 8, 2023

@kialj876 - Pls check
Add an individual- keep the “Add an Individual” button visible above the Add Form. Dim / disable the button while the form is open.

image.png

@gunanagar
Copy link
Collaborator

Tested - Add an individual- keep the “Add an Individual” button visible above the Add Form. Dim / disable the button while the form is open.

Screen Shot 2023-12-08 at 6.34.21 PM.png

@fodiley fodiley closed this as completed Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BTR Business Transparency Register Register BO
Projects
None yet
Development

No branches or pull requests

5 participants