Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Media Player to 2.5.0 into Simorgh #5161

Closed
wants to merge 17 commits into from

Conversation

simonsinclair
Copy link
Contributor

@simonsinclair simonsinclair commented Jan 15, 2020

Overall change:
These changes introduce Psammead Media Player 2.5.0, which handles timeouts for AV embeds.

Code changes:

  • Update package.json and package.lock.json.
  • Update seven relevant snapshots.

Notes:

  • 2.4.1
  • 2.4.2
  • 2.4.3
  • 2.4.4
  • 2.4.5
  • 2.5.0

  • I have assigned myself to this PR and the corresponding issues
  • I have added labels to this PR for the relevant pod(s) affected by these changes
  • I have assigned this PR to the Simorgh project

Testing:

  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive)
  • This PR requires manual testing

@simonsinclair simonsinclair added ws-articles Tasks for the WS Articles Team ws-home ws-media World Service Media labels Jan 15, 2020
@simonsinclair simonsinclair self-assigned this Jan 15, 2020
@simonsinclair simonsinclair marked this pull request as ready for review January 15, 2020 12:53
@amywalkerdev
Copy link
Contributor

This probably needs #5142 to be merged first as it bumps gel foundations

Copy link
Contributor

@12 12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@simonsinclair simonsinclair changed the title Bump Media Player to 2.5.0 Integrate Media Player to 2.5.0 into Simorgh Jan 17, 2020
@amywalkerdev
Copy link
Contributor

articles - news - Canonical Canonical Tests for news articles Media Player: Canonical plays media when a user clicks play:
�[0m�[31m CypressError: Timed out retrying: cy.its() errored because the property: 'embeddedMedia' does not exist on your subject.

@simonsinclair
Copy link
Contributor Author

simonsinclair commented Jan 22, 2020

Attaching an on load event to Canonical MP in 2.5.0 has created a strange interaction with some of our e2e tests in Simorgh. This is likely due to a bug in Cypress, but until we can afford more time to solve this problem a manual revert of this feature has been issued: BBC-archive/psammead#2991

Cc @jamesdonoh.

@simonsinclair simonsinclair deleted the bump-media-player branch January 22, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ws-articles Tasks for the WS Articles Team ws-media World Service Media
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants