-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Media Player to 2.5.0 into Simorgh #5161
Conversation
This probably needs #5142 to be merged first as it bumps gel foundations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
articles - news - Canonical Canonical Tests for news articles Media Player: Canonical plays media when a user clicks play: |
Attaching an on Cc @jamesdonoh. |
Waiting on Dependency updates - all dependabot PRs combined #5142.local
, but nottest
.Overall change:
These changes introduce Psammead Media Player 2.5.0, which handles timeouts for AV embeds.
Code changes:
package.json
andpackage.lock.json
.Notes:
Testing:
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive
)