This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Revert 2836 - Add AV embed timeout handling to MP #2991
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall change: This is a manual revert of #2836, which added AV embed timeout handling to Media Player. We had to revert this due to a strange interaction with Simorgh's e2e tests, which could be related to a bug in Cypress. See below for additional context. Until we can offer this issue more time, this functionality will be reverted.
Code changes:
Additional context:
load
event handler to Canonical MP iframe causes the first e2e test that accesses the iframe'scontentWindow
property to fail. Subsequent tests will pass. It does not matter on the order of these tests - the first one will always fail.