Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use latest storybook helper #2727

Merged
merged 2 commits into from
Jul 25, 2019
Merged

use latest storybook helper #2727

merged 2 commits into from
Jul 25, 2019

Conversation

thekp
Copy link
Contributor

@thekp thekp commented Jul 25, 2019

Resolves: #2719

Overall change: Uses latest storybook helper which fixes the way we import scripts from gel-foundations. This should fix the currently broken storybook containers. change made in this PR: BBC-archive/psammead#1479

Code changes:

  • bump psammead-storybook-helper to v3.3.1

  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

Copy link

@dr3 dr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge merge merrrggee

@PriyaKR
Copy link
Contributor

PriyaKR commented Jul 25, 2019

LGTM.

@chris-hinds chris-hinds merged commit 83b16bc into latest Jul 25, 2019
@chris-hinds chris-hinds deleted the bump-storybook-helper branch July 25, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simorgh stories not rendering in storybook
4 participants