Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simorgh stories not rendering in storybook #2719

Closed
chris-hinds opened this issue Jul 24, 2019 · 0 comments · Fixed by #2727
Closed

Simorgh stories not rendering in storybook #2719

chris-hinds opened this issue Jul 24, 2019 · 0 comments · Fixed by #2727
Labels
bug Something isn't working
Milestone
Simorgh 2.0

Comments

@chris-hinds
Copy link
Contributor

chris-hinds commented Jul 24, 2019 •
edited
Loading

Describe the bug
A set of stories on the simorgh storybook are not working due to the input-provider not having the config for the service/script passed in.

Affected Stories:

  • Article main
  • Brand container
  • Copyright container
  • Footer container
  • Frontpage container
  • Header container

Example: https://bbc.github.io/simorgh/?path=/story/article-main--default

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://bbc.github.io/simorgh/?path=/story/article-main--default'
  2. See error

Expected behavior
To render the chosen story

Screenshots
image
@chris-hinds chris-hinds added bug Something isn't working simorgh-core-stream labels Jul 24, 2019
@chris-hinds chris-hinds added this to the Simorgh 2.0 milestone Jul 24, 2019
@thekp thekp mentioned this issue Jul 25, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Simorgh 2.0
Development

Successfully merging a pull request may close this issue.

use latest storybook helper bbc/simorgh
1 participant
@chris-hinds