add direction rtl to footer container story #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 3, 2019 10:50
thekp
force-pushed
the
Update-footerContainer-in-storybook
branch
from
8dc7c39 to
4ecaeda
Compare
thekp
changed the title
|
At the moment, the dropdown of services is not restricted to existing services. However, this issue will cover this: BBC-archive/psammead#757 |
thekp
added
the
blocked
thekp
removed
the
blocked
thekp
requested review from
jamesbhobbs,
dr3,
chris-hinds,
jamesdonoh and
j-pendlebury
as code owners
ryanmccombe
reviewed
Jul 4, 2019
| storiesOf('Footer', module) | ||
| .addDecorator(withKnobs) | ||
| .add( | ||
| 'testing', |
There was a problem hiding this comment.
I guess this label was a placeholder?
There was a problem hiding this comment.
nope, miss named there... will update shortly :)
ryanmccombe
approved these changes
Jul 4, 2019
dr3
approved these changes
Jul 4, 2019
|
@thekp Looks good to me.(Can we make the container title as |
added 2 commits
July 8, 2019 14:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2197
blocked by: BBC-archive/psammead#758 and BBC-archive/psammead#770
Overall change: Update footer container storybook to have a dropdown of services and have RTL direction for required services.
Code changes:
Test notes: