Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Allow restricting inputProvider services #757

Closed
dr3 opened this issue Jul 2, 2019 · 0 comments · Fixed by #758
Closed

Allow restricting inputProvider services #757

dr3 opened this issue Jul 2, 2019 · 0 comments · Fixed by #758
Assignees
Labels
simorgh-core-stream ws-home Tasks for the WS Home Team

Comments

@dr3
Copy link
Contributor

dr3 commented Jul 2, 2019

Is your feature request related to a problem? Please describe.
Currently the input provider provides all 40-something services. This isn't ideal as you cant use it to toggle variants of a component as you may not have all the config (e.g. footer) or assets (.e.g svgs)

Describe the solution you'd like
Add a 3rd argument to inputProvider() which is an array of services. It should then filter out unwanted services from its drop down.

Testing notes
[Tester to complete]

Dev insight: Test in storybook, a story will have a restricted list of services to pick.

Additional context
Add any other context or screenshots about the feature request here.

@dr3 dr3 added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-home Tasks for the WS Home Team simorgh-core-stream labels Jul 2, 2019
@dr3 dr3 removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Jul 3, 2019
@dr3 dr3 self-assigned this Jul 3, 2019
@dr3 dr3 closed this as completed in #758 Jul 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
simorgh-core-stream ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant