Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update brand component to the latest version. #1805

Closed
ghost opened this issue May 28, 2019 · 0 comments · Fixed by #1876
Closed

Update brand component to the latest version. #1805

ghost opened this issue May 28, 2019 · 0 comments · Fixed by #1876
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented May 28, 2019

Is your feature request related to a problem? Please describe.

Following Psammead#528 and Psammead#480 Brand now allows for scaling of the brand svg and dynamic link. Simorgh still runs version 1.0.1 while Brand is at version 3.0.0

When the brand is clicked it should take the user to the website home page (in the front page case it's the page the user is already on):

Igbo: https://www.bbc.com/igbo
Yoruba: https://www.bbc.com/yoruba
Pidgin: https://www.bbc.com/pidgin

Describe the solution you'd like
Update @bbc/psammead-brand to latest version and add links to service config so that it can be passed via ServiceContext

Describe alternatives you've considered
N/A

Testing notes
[Tester to complete]

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

Additional context
Add any other context or screenshots about the feature request here.

@ghost ghost added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-frontpage-stream labels May 28, 2019
@clareevansbbc clareevansbbc added this to the Brand (WS FP) milestone May 29, 2019
@ghost ghost removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Jun 4, 2019
@Bopchy Bopchy self-assigned this Jun 6, 2019
@ghost ghost closed this as completed in #1876 Jun 26, 2019
@ghost ghost mentioned this issue Jun 27, 2019
4 tasks
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants