This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Control height of Brand SVG #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-nowak
requested review from
jamesbhobbs,
dr3,
chris-hinds,
jamesdonoh,
j-pendlebury,
pjlee11 and
sareh
as code owners
dr3
suggested changes
Apr 29, 2019
packages/components/psammead-brand/src/__snapshots__/index.test.jsx.snap
Outdated
Show resolved
Hide resolved
stops React rendering the heights object
Co-Authored-By: aacn500 <10963046+aacn500@users.noreply.github.com>
|
Has this had a developer accessibility swarm carried out on it? |
|
@greenc05 good point, this PR pre-dated the developer accessibility swarm workflow so will need one. |
DenisHdz
approved these changes
May 17, 2019
|
Developer accessibility swarm complete! |
12
approved these changes
May 17, 2019
ghost
mentioned this pull request
|
Still looks good, RFM. |
j-pendlebury
approved these changes
May 20, 2019
dr3
approved these changes
May 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #466
Resolves #499
Overall change: Height of the SVG in the Brand component is dynamically scaled between the prop values
minWidthandmaxWidth. Also the Banner height and padding changes at 600px.Code changes:
minWidthandmaxWidthvalues.margin-topminWidthmaxWidthandheightto showcase the flexibility of the component and the dynamic scaling of the SVGTesting notes
Check the brand component in storybook and test cross browser the functionality to dynamically scale the SVG's at small widths works as expected.