This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Dynamic brand link #528
Merged
Dynamic brand link #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
ghost
marked this pull request as ready for review
ghost
requested review from
jamesbhobbs,
dr3,
chris-hinds,
jamesdonoh,
j-pendlebury,
pjlee11 and
sareh
as code owners
pjlee11
reviewed
May 17, 2019
12
suggested changes
May 17, 2019
dr3
reviewed
May 21, 2019
dr3
reviewed
May 21, 2019
andrew-nowak
suggested changes
May 21, 2019
packages/components/psammead-brand/src/__snapshots__/index.test.jsx.snap
Outdated
Show resolved
Hide resolved
packages/components/psammead-brand/src/__snapshots__/index.test.jsx.snap
Outdated
Show resolved
Hide resolved
…into dynamic-brand-link
andrew-nowak
approved these changes
May 21, 2019
dr3
approved these changes
May 21, 2019
|
LGTM. Happy for this to be merged. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #500
Overall change: Make Branding href link dynamic to allow passing of different service links.
Code changes:
linkprop which is required to allow passing of the service url to brandBrandBrandwith link not provided.