This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Add ability to limit service options #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ive noticed it says 'language' in the provider still (even though we previously changed from 'english' to 'news', moving to using services), ive raised #759 to update this to 'services' |
|
Should this also be done to |
pjlee11
approved these changes
Jul 3, 2019
DenisHdz
approved these changes
Jul 3, 2019
|
Chatted with @sadickisaac on slack, gunna write an issue #770 to allow limiting the Dir decorator per service. Just added some more tests for the input provider |
thekp
suggested changes
Jul 3, 2019
2 tasks
|
No testing needed, will fix forward any issues, limited scope due to being storybook helper and unit tests pass |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #757
Overall change: Add ability to limit service options in input provider
Code changes:
[ ] Tests added for new features