This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Add lang attribute to brand component #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EinsteinNjoroge
requested review from
j-pendlebury,
pjlee11 and
sareh
as code owners
ghost
suggested changes
Jun 11, 2019
dr3
reviewed
Jun 11, 2019
ghost
suggested changes
Jun 12, 2019
|
Don't forget to bump version of the |
ghost
reviewed
Jun 12, 2019
DenisHdz
reviewed
Jun 12, 2019
4 tasks
DenisHdz
previously approved these changes
Jun 12, 2019
ghost
mentioned this pull request
pjlee11
suggested changes
Jun 13, 2019
ghost
suggested changes
Jun 13, 2019
ghost
suggested changes
Jun 13, 2019
Co-Authored-By: sadickisaac <48688870+sadickisaac@users.noreply.github.com>
j-pendlebury
approved these changes
Jun 14, 2019
|
Hi @EinsteinCarrey , Is this definitely required to be en-GB? In https://www.w3.org/International/questions/qa-html-language-declarations#langvalues it says it should be en. Cheers |
|
I've read that en-GB is also valid. This is ready for merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #607
Overall change: Adds a lang attribute ie "en-GB" to ensure brand name ie
BBC newsis read with the correct accents"Code changes:
-Wrap "BBC news" text inside a span with a lang attribute with the value set to "en_GB"
-Change the brand components expected props from
brandNametoproductandserviceLocalisedNameNote This calls for changes on the implementation of Brand in Simorgh