This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Add lang attribute to the brand component #607
Comments
Would this be better as 2 Issues? One for the lang attribute and one for the visually hidden text? |
Testing notes on brand with 2 languages if that is useful @sadick254 https://docs.google.com/document/d/14A0JcYeBvIbg2aHa_4b3eQIG768U9GaCHnNameDKMQ8/edit?usp=sharing |
to
|
Is |
I believe so, but the |
Lets not forget the comma please "BBC News, Yorùbá" |
3 tasks
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Is your feature request related to a problem? Please describe.
We currently don't have a lang attribute defined for the Brand Component which would help screen readers to announce brand name in the correct accent. i.e `BBC News’ is announced with an English accent.
Describe the solution you'd like
Add a
lang
attribute to theBrand
component.Describe alternatives you've considered
N/A
Testing notes
[Tester to complete]
Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: