Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Update brand component story on storybook #606

Closed
ghost opened this issue Jun 11, 2019 · 1 comment · Fixed by #642
Closed

Update brand component story on storybook #606

ghost opened this issue Jun 11, 2019 · 1 comment · Fixed by #642
Assignees
@Bopchy
Labels
ws-home Tasks for the WS Home Team
Milestone
Brand (WS FP)

Comments

@ghost
Copy link

ghost commented Jun 11, 2019 •
edited by ghost
Loading

Is your feature request related to a problem? Please describe.
When a different service is chosen from the knob the visually hidden text on the Brand component doesn't update.

Describe the solution you'd like
Provide a knob to allow changing of the visually hidden text

Testing notes
[Tester to complete]

Dev insight: No test needed only visually checking the DOM for updates.

Additional context
Add any other context or screenshots about the feature request here.
@ghost ghost added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-home Tasks for the WS Home Team ws-fp-v1 labels Jun 11, 2019
@ghost ghost added this to the Brand (WS FP) milestone Jun 11, 2019
@andrew-nowak andrew-nowak removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Jun 12, 2019
@Bopchy Bopchy self-assigned this Jun 12, 2019
@ghost ghost added the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Jun 12, 2019
@ghost ghost changed the title Upate brand component story on storybook Update brand component story on storybook Jun 12, 2019
@Bopchy
Copy link
Contributor

Bopchy commented Jun 13, 2019 •
edited
Loading

This needs #609 to be merged so that knob can be added to the updated code

@Bopchy Bopchy removed their assignment Jun 13, 2019
@ghost ghost removed the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Jun 17, 2019
@Bopchy Bopchy self-assigned this Jun 17, 2019
This was referenced Jun 17, 2019
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Bopchy Bopchy

Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
Brand (WS FP)
Development

Successfully merging a pull request may close this issue.

Update brand component story on Storybook BBC-archive/psammead
2 participants
@andrew-nowak @Bopchy