Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Update brand component story on Storybook #642

Merged
merged 10 commits into from
Jun 18, 2019

Conversation

Bopchy
Copy link
Contributor

@Bopchy Bopchy commented Jun 17, 2019

Resolves #606

Overall change: Update brand component story on Storybook to include knobs for product and serviceLocalisedName.

Code changes:

  • Add knobs for product and serviceLocalisedName to the brand component story on Storybook..

  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@Bopchy Bopchy self-assigned this Jun 17, 2019
@Bopchy Bopchy added ws-fp-v1 ws-home Tasks for the WS Home Team labels Jun 17, 2019
@Bopchy Bopchy marked this pull request as ready for review June 17, 2019 13:26
packages/components/psammead-brand/CHANGELOG.md Outdated Show resolved Hide resolved
packages/components/psammead-brand/package.json Outdated Show resolved Hide resolved
packages/components/psammead-brand/src/index.stories.jsx Outdated Show resolved Hide resolved
@Bopchy Bopchy requested a review from a user June 18, 2019 07:46
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@j-pendlebury j-pendlebury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@david-boydell david-boydell self-assigned this Jun 18, 2019
@david-boydell
Copy link

Looks good, ready for merge.

@amywalkerdev amywalkerdev merged commit dfd4940 into latest Jun 18, 2019
@amywalkerdev amywalkerdev deleted the 606-update-brand-component-story-on-storybook branch June 18, 2019 11:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update brand component story on storybook
4 participants