This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Migrate [level 2] packages to Emotion #3891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Simon Sinclair <simon.sinclair@bbc.co.uk>
simonsinclair
added
technical-work
ryanmccombe
reviewed
Oct 16, 2020
ryanmccombe
reviewed
Oct 16, 2020
| const paddingDir = ({ dir }) => `padding-${dir === 'rtl' ? 'left' : 'right'}`; | ||
|
|
||
| const TextGridColumnsTopStory = css` | ||
| const TextGridColumnsTopStory = ` |
There was a problem hiding this comment.
Did we do a visual comparison on storybook between this branch and the storybook on github? Lot of changes here 👍
ryanmccombe
approved these changes
Oct 16, 2020
simonsinclair
commented
Oct 16, 2020
RichardPK
approved these changes
Oct 16, 2020
Co-authored-by: Simon Sinclair <simon.sinclair@bbc.co.uk>
…psammead into lvl2-migrate-psammead-simon
L2 - Emotion
[level 2] Migrate copyright & consent-banner
[level 2] Migrate bulleted list & heading index
Co-authored-by: Ryan McCombe <ryanmccombe@gmail.com>
…migrate-section-label
[level 2] Migrate section label to emotion
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #3763.
Overall change:
Code changes: