Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

[level 2] Migrate bulleted list & heading index #3888

Merged
merged 5 commits into from
Oct 16, 2020
Merged

[level 2] Migrate bulleted list & heading index #3888

merged 5 commits into from
Oct 16, 2020

Conversation

RichardPK
Copy link
Contributor

@RichardPK RichardPK commented Oct 15, 2020 •
edited by simonsinclair
Loading

Relates to #3763.

Overall change: A very high-level summary of easily-reproducible changes that can be understood by non-devs.

Code changes:

  • A bullet point list of key code changes that have been made.
  • When describing code changes, try to communicate how and why you implemented something a specific way, not just what has changed.
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@RichardPK RichardPK changed the title [level 2] Migrate bulleted list [level 2] Migrate bulleted list & heading index Oct 15, 2020
@RichardPK RichardPK marked this pull request as ready for review October 15, 2020 14:46
@simonsinclair simonsinclair added cross-team For visibility for both World Service teams (Engage & Media) technical-work Technical debt, support work and building new technical tools and features labels Oct 15, 2020
@simonsinclair simonsinclair added this to the Migrate to Emotion milestone Oct 15, 2020
@RichardPK RichardPK changed the base branch from latest to lvl2-migrate-psammead-simon October 16, 2020 09:57
@RichardPK RichardPK merged commit d902df7 into lvl2-migrate-psammead-simon Oct 16, 2020
@bbc-news-frameworks bbc-news-frameworks mentioned this pull request Oct 16, 2020
Merged
@RichardPK RichardPK deleted the migrate-bulleted-list branch January 20, 2021 10:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanmccombe ryanmccombe ryanmccombe approved these changes

Assignees

@RichardPK RichardPK

Labels
cross-team For visibility for both World Service teams (Engage & Media) technical-work Technical debt, support work and building new technical tools and features
Projects
None yet
Milestone
Migrate to Emotion
Development

Successfully merging this pull request may close these issues.
3 participants
@RichardPK @ryanmccombe @simonsinclair