Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

L2 - Emotion #3890

Merged
merged 14 commits into from
Oct 16, 2020
Merged

L2 - Emotion #3890

merged 14 commits into from
Oct 16, 2020

Conversation

ryanmccombe
Copy link
Contributor

@ryanmccombe ryanmccombe commented Oct 15, 2020 •
edited by simonsinclair
Loading

Relates to #3763

Overall change: A very high-level summary of easily-reproducible changes that can be understood by non-devs.

Code changes:

  • A bullet point list of key code changes that have been made.
  • When describing code changes, try to communicate how and why you implemented something a specific way, not just what has changed.
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@ryanmccombe ryanmccombe marked this pull request as ready for review October 15, 2020 15:03
@simonsinclair simonsinclair added cross-team For visibility for both World Service teams (Engage & Media) technical-work Technical debt, support work and building new technical tools and features labels Oct 15, 2020
@simonsinclair simonsinclair added this to the Migrate to Emotion milestone Oct 15, 2020
simonsinclair
simonsinclair approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@simonsinclair simonsinclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect.

packages/components/psammead-social-embed/CHANGELOG.md Outdated Show resolved Hide resolved
RichardPK
RichardPK reviewed Oct 16, 2020
View reviewed changes
packages/components/psammead-paragraph/package.json Outdated
@@ -28,6 +28,7 @@
"@bbc/psammead-styles": "^6.0.0"
},
"peerDependencies": {
"styled-components": "^4.3.2"
"styled-components": "^4.3.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely not 🦀

RichardPK
RichardPK approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@RichardPK RichardPK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that peer dependency 👍

@ryanmccombe ryanmccombe changed the base branch from latest to lvl2-migrate-psammead-simon October 16, 2020 09:57
@ryanmccombe ryanmccombe merged commit a1fd13f into lvl2-migrate-psammead-simon Oct 16, 2020
@bbc-news-frameworks bbc-news-frameworks mentioned this pull request Oct 16, 2020
Merged
@joshcoventry joshcoventry deleted the emotion-level-2 branch May 10, 2021 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simonsinclair simonsinclair simonsinclair approved these changes

@RichardPK RichardPK RichardPK approved these changes

Assignees

@ryanmccombe ryanmccombe

Labels
cross-team For visibility for both World Service teams (Engage & Media) technical-work Technical debt, support work and building new technical tools and features
Projects
None yet
Milestone
Migrate to Emotion
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanmccombe @simonsinclair @RichardPK