This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Inline link padding on default styling #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjlee11
commented
Jul 11, 2019
| | 1.1.7 | [PR#892](https://github.com/bbc/psammead/pull/892) Bump dependencies | | ||
| | 1.1.6 | [PR#942](https://github.com/bbc/psammead/pull/942) Revert new inline-link styling due to [bug](https://github.com/bbc/simorgh/issues/2370) | | ||
| | 1.1.5 | [PR#783](https://github.com/bbc/psammead/pull/783) Update to latest psammead-test-helpers. Update snapshots. | | ||
| | 1.1.4 | [PR#769](https://github.com/bbc/psammead/pull/769) Fix stories not appearing in storybook when using `install:packages:link` | | ||
| | 1.1.3 | [PR#775](https://github.com/bbc/psammead/pull/775) Add section to readme regarding using this component without a wrapper and padding/margin | | ||
| | 1.1.2 | [PR#687](https://github.com/bbc/psammead/pull/687) Change visited text colour to `C_CLOUD_DARK` for `C_METAL` | | ||
| | 1.1.1 | [PR#761](https://github.com/bbc/psammead/pull/761) Link default `color` should be `Ebon` not `Postbox` | | ||
| | 1.1.0 | [PR#719](https://github.com/bbc/psammead/pull/719) Updates the link styling to new UX designs | | ||
| | 1.1.0 | [PR#707](https://github.com/bbc/psammead/pull/707) Updates the link styling to new UX designs | |
There was a problem hiding this comment.
Incorrect link from previous
added 2 commits
July 11, 2019 12:43
|
New styling in hover/focus state:
|
added 3 commits
July 15, 2019 15:35
…bc/psammead into inline-link-padding-on-default-styling
dr3
approved these changes
Jul 16, 2019
|
LGTM |
1 task
This was referenced Oct 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1024
Resolves #777
Overall change: Sets the background colour to red, text colour to white during hover and focus states. Adds left/right padding and minus margin to increase buffer between the glyphs and background colour for legibility reasons. Adds pre-wrap to enhance legibility on the end of a line when the link wraps to a new line.
Code changes:
Testing notes:
npm run build && cp packages/components/psammead-inline-link/dist/index.js packages/components/psammead-caption/node_modules/@bbc/psammead-inline-link/dist/index.js && cp packages/components/psammead-inline-link/dist/index.js packages/components/psammead-paragraph/node_modules/@bbc/psammead-inline-link/dist/index.js && npm run storybook