Merge pull request #1023 from bbc/inline-link-padding-on-default-styling

Inline link padding on default styling
BBC-archive · Jul 16, 2019 · c0f967b · c0f967b
2 parents d345933 + 4b43fe8
commit c0f967b
Show file tree

Hide file tree

Showing 6 changed files with 60 additions and 108 deletions.
diff --git a/packages/components/psammead-inline-link/CHANGELOG.md b/packages/components/psammead-inline-link/CHANGELOG.md
@@ -3,7 +3,8 @@
 <!-- prettier-ignore -->
 | Version | Description |
 |---------|-------------|
-| 1.1.10   | [PR#1181](https://github.com/bbc/psammead/pull/1181) use `psammead-styles@1.1.3`, `psammead-storybook-helpers@3.1.3`, `psammead-test-helpers@1.0.2`|
+| 1.1.11-alpha.1 | [PR#1023](https://github.com/bbc/psammead/pull/1023) Default styling should have padding and margin to fix hover/focus bug |
+| 1.1.10  | [PR#1181](https://github.com/bbc/psammead/pull/1181) use `psammead-styles@1.1.3`, `psammead-storybook-helpers@3.1.3`, `psammead-test-helpers@1.0.2`|
 | 1.1.9   | [PR#1082](https://github.com/bbc/psammead/pull/1082) Bump lodash security vulnerability |
 | 1.1.8 | [PR#1038](https://github.com/bbc/psammead/pull/1038) Bump dependencies |
 | 1.1.7 | [PR#892](https://github.com/bbc/psammead/pull/892) Bump dependencies |
@@ -13,7 +14,7 @@
 | 1.1.3 | [PR#775](https://github.com/bbc/psammead/pull/775) Add section to readme regarding using this component without a wrapper and padding/margin |
 | 1.1.2 | [PR#687](https://github.com/bbc/psammead/pull/687) Change visited text colour to `C_CLOUD_DARK` for `C_METAL` |
 | 1.1.1 | [PR#761](https://github.com/bbc/psammead/pull/761) Link default `color` should be `Ebon` not `Postbox` |
-| 1.1.0 | [PR#719](https://github.com/bbc/psammead/pull/719) Updates the link styling to new UX designs |
+| 1.1.0 | [PR#707](https://github.com/bbc/psammead/pull/707) Updates the link styling to new UX designs |
 | 1.0.1 | [PR#713](https://github.com/bbc/psammead/pull/713) Update `styled-components` to 4.3.2 |
 | 1.0.0 | [PR#679](https://github.com/bbc/psammead/pull/679) Bump version number |
 | 0.3.8 | [PR#498](https://github.com/bbc/psammead/pull/498) Update stories to use new input provider |

diff --git a/packages/components/psammead-inline-link/README.md b/packages/components/psammead-inline-link/README.md
@@ -69,8 +69,6 @@ const WrapperComponent = () => (
 );
 ```
 
-This component is designed to be used inline of another text based component. If using this component without a wrapping component then typography values will need to be added by extending the styles. We strongly suggest that when using this component the page has padding or margin of 2px or more between this component and the edges of the viewport, whenever using this in production. For further details please see this [issue](https://github.com/bbc/psammead/pull/746) and in particular this [comment](https://github.com/bbc/psammead/pull/746#issuecomment-508367126). Also it is good practice in terms of legibility to have spacing between the edge of the viewport and any text content. 
-
 ### When to use this component
 
 This component can be used at any point on a page.
-Original file line number
+Diff line change
@@ Expand Up / @@ -69,8 +69,6 @@ const WrapperComponent = () => ( @@
     );
     ```
-    This component is designed to be used inline of another text based component. If using this component without a wrapping component then typography values will need to be added by extending the styles. We strongly suggest that when using this component the page has padding or margin of 2px or more between this component and the edges of the viewport, whenever using this in production. For further details please see this [issue](https://github.com/bbc/psammead/pull/746) and in particular this [comment](https://github.com/bbc/psammead/pull/746#issuecomment-508367126). Also it is good practice in terms of legibility to have spacing between the edge of the viewport and any text content.
     ### When to use this component
     This component can be used at any point on a page.
@@ Expand Down @@