Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Inline link padding on default styling #1023

Merged
merged 18 commits into from
Jul 16, 2019
Merged

Inline link padding on default styling #1023

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b8d694e
changelog incorrect PR number
Jul 9, 2019
a4372f5
the bug refered in the readme is also fixed in this change
Jul 9, 2019
2da91b4
add padding and minus margin to default styling + changelog
Jul 9, 2019
e178831
snapshot bump
Jul 9, 2019
810d4ac
pull latest; fix conflicts; use REMs
Jul 11, 2019
a77ef0e
snapshots
Jul 11, 2019
ae3dae6
alpha tag and version number
Jul 11, 2019
c5ab07a
2px = 0.125
Jul 11, 2019
24377a4
snapshot and PR number
Jul 11, 2019
bf6fc3f
merge latest, fix conflicts
Jul 11, 2019
1ee2a16
merge latest and fix conflicts
Jul 11, 2019
8e77619
Merge branch 'latest' into inline-link-padding-on-default-styling
Jul 11, 2019
bcb941b
Merge branch 'latest' into inline-link-padding-on-default-styling
12 Jul 12, 2019
e69d65b
merge latest fix conflicts
Jul 15, 2019
f6a0fc5
Merge branch 'inline-link-padding-on-default-styling' of github.com:b…
Jul 15, 2019
7aba0a2
Merge branch 'latest' into inline-link-padding-on-default-styling
Jul 15, 2019
b5f8f9a
Merge branch 'latest' into inline-link-padding-on-default-styling
Jul 15, 2019
4b43fe8
Merge branch 'latest' into inline-link-padding-on-default-styling
amywalkerdev Jul 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/components/psammead-inline-link/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<!-- prettier-ignore -->
| Version | Description |
|---------|-------------|
| 1.1.9-alpha.1 | [PR#1023](https://github.com/bbc/psammead/pull/1023) Default styling should have padding and margin to fix hover/focus bug |
| 1.1.8 | [PR#1038](https://github.com/bbc/psammead/pull/1038) Bump dependencies |
| 1.1.7 | [PR#892](https://github.com/bbc/psammead/pull/892) Bump dependencies |
| 1.1.6 | [PR#942](https://github.com/bbc/psammead/pull/942) Revert new inline-link styling due to [bug](https://github.com/bbc/simorgh/issues/2370) |
Expand All @@ -11,7 +12,7 @@
| 1.1.3 | [PR#775](https://github.com/bbc/psammead/pull/775) Add section to readme regarding using this component without a wrapper and padding/margin |
| 1.1.2 | [PR#687](https://github.com/bbc/psammead/pull/687) Change visited text colour to `C_CLOUD_DARK` for `C_METAL` |
| 1.1.1 | [PR#761](https://github.com/bbc/psammead/pull/761) Link default `color` should be `Ebon` not `Postbox` |
| 1.1.0 | [PR#719](https://github.com/bbc/psammead/pull/719) Updates the link styling to new UX designs |
| 1.1.0 | [PR#707](https://github.com/bbc/psammead/pull/707) Updates the link styling to new UX designs |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect link from previous

| 1.0.1 | [PR#713](https://github.com/bbc/psammead/pull/713) Update `styled-components` to 4.3.2 |
| 1.0.0 | [PR#679](https://github.com/bbc/psammead/pull/679) Bump version number |
| 0.3.8 | [PR#498](https://github.com/bbc/psammead/pull/498) Update stories to use new input provider |
Expand Down
2 changes: 0 additions & 2 deletions packages/components/psammead-inline-link/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,6 @@ const WrapperComponent = () => (
);
```

This component is designed to be used inline of another text based component. If using this component without a wrapping component then typography values will need to be added by extending the styles. We strongly suggest that when using this component the page has padding or margin of 2px or more between this component and the edges of the viewport, whenever using this in production. For further details please see this [issue](https://github.com/bbc/psammead/pull/746) and in particular this [comment](https://github.com/bbc/psammead/pull/746#issuecomment-508367126). Also it is good practice in terms of legibility to have spacing between the edge of the viewport and any text content.

### When to use this component

This component can be used at any point on a page.
Expand Down
Loading