-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support . workspace member #1326
Merged
illicitonion
merged 4 commits into
bazelbuild:main
from
illicitonion:dot-workspace-members
May 9, 2022
Merged
Support . workspace member #1326
illicitonion
merged 4 commits into
bazelbuild:main
from
illicitonion:dot-workspace-members
May 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suggest reviewing commit-by-commit, last commit is just a re-vendoring. |
UebelAndre
requested changes
May 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a few nits.
illicitonion
force-pushed
the
dot-workspace-members
branch
from
May 9, 2022 15:29
f46557a
to
ff8338d
Compare
Previously, if a workspace included `.` as a member, we could consistently error and nothing could be done about it.
This is used as a staging ground for local repositories when iterating locally.
This adds normpath, and otherwise is just updates.
illicitonion
force-pushed
the
dot-workspace-members
branch
from
May 9, 2022 15:31
ff8338d
to
f6a6872
Compare
UebelAndre
approved these changes
May 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a workspace included
.
as a member, we couldconsistently error and nothing could be done about it.
Fixes #1321