Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support . workspace member #1326

Merged
merged 4 commits into from
May 9, 2022

Conversation

illicitonion
Copy link
Collaborator

@illicitonion illicitonion commented May 9, 2022

Previously, if a workspace included . as a member, we could
consistently error and nothing could be done about it.

Fixes #1321

@illicitonion illicitonion requested a review from UebelAndre May 9, 2022 10:18
@illicitonion
Copy link
Collaborator Author

I suggest reviewing commit-by-commit, last commit is just a re-vendoring.

Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a few nits.

crate_universe/src/splicing/splicer.rs Outdated Show resolved Hide resolved
crate_universe/src/splicing/splicer.rs Outdated Show resolved Hide resolved
crate_universe/src/splicing/splicer.rs Outdated Show resolved Hide resolved
@illicitonion illicitonion force-pushed the dot-workspace-members branch from f46557a to ff8338d Compare May 9, 2022 15:29
Previously, if a workspace included `.` as a member, we could
consistently error and nothing could be done about it.
This is used as a staging ground for local repositories when iterating
locally.
This adds normpath, and otherwise is just updates.
@illicitonion illicitonion force-pushed the dot-workspace-members branch from ff8338d to f6a6872 Compare May 9, 2022 15:31
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@illicitonion illicitonion merged commit d3d9aba into bazelbuild:main May 9, 2022
@illicitonion illicitonion deleted the dot-workspace-members branch May 9, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crates_repository fails if a workspace contains . as a member
2 participants