Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crates_repository fails if a workspace contains . as a member #1321

Closed
illicitonion opened this issue May 6, 2022 · 0 comments · Fixed by #1326
Closed

crates_repository fails if a workspace contains . as a member #1321

illicitonion opened this issue May 6, 2022 · 0 comments · Fixed by #1326

Comments

@illicitonion
Copy link
Collaborator

This Cargo.toml:

[workspace]

members = [
  ".",
  "hello-lib",
]

[package]
name = "hello-rust"
version = "0.1.0"
edition = "2018"

[dependencies]
hello-lib = { path = "hello-lib" }
hex = "0.4.2"

currently fails to generate a repository because of this error:

Error: Some manifests are not being tracked. Please add the following labels to the `manifests` key: {
    "//package:Cargo.toml",
}

where package is the package containing the above Cargo.toml.

We should do the path normalisation to absolute paths before filtering, and normalise out any /./ or /../ path segments too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants