Remove tree artifacts #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t, new location TBD
…azelbuild#283) * Update readme so the dev instructions highlight using a local clone * Typo and make a faux-path.
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
restingbull
force-pushed
the
remove-tree-artifacts
branch
from
30c87ee
to
4926a05
Compare
Closed
|
@googlebot I consent. |
1 similar comment
|
@googlebot I consent. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
cgruber
reviewed
Feb 27, 2020
|
I'm LGTM on these two subsequent commits, but let's get the other one merged and rebase this on that, so we can make sure I'm looking at the correct set of commits. |
restingbull
force-pushed
the
remove-tree-artifacts
branch
2 times, most recently
from
38b868d
to
e1d9d5a
Compare
added 5 commits
February 27, 2020 12:29
Move toolchain configuration to the toolchains.bzl Issue: bazelbuild#269 (comment)
Added //:rules_kotlin_release to build a release. Issue: bazelbuild#269 (comment)
Make examples use the release repository Issue: bazelbuild#269 (comment)
Make examples use the release repository Make git ignore profiling artifacts Issue: bazelbuild#269 (comment)
added 2 commits
February 27, 2020 12:29
… Tree artifacts, (created by declare_directory) are only useful when an action produces an unknown number of outputs. It this case, this would only result in extra overhead of bundling the produced directories in archives with ever using them.
restingbull
force-pushed
the
remove-tree-artifacts
branch
from
a4cd02a
to
28d020d
Compare
|
Ok, so post-hoc LGTM I guess. :) |
cromwellian
pushed a commit
to cromwellian/rules_kotlin
that referenced
this pull request
Mar 7, 2020
remove the generation of unused tree artifacts from the compile step. Tree artifacts, (created by declare_directory) are only useful when an action produces an unknown number of outputs. It this case, this would only result in extra overhead of bundling the produced directories in archives with ever using them. Co-authored-by: Christian Edward Gruber <christianedwardgruber@gmail.com>
cgruber
added a commit
to cgruber/rules_kotlin
that referenced
this pull request
Apr 14, 2020
* upstream/master: Fix non-reproducible archives (bazelbuild#304) Adds a kt_plugin rule (bazelbuild#308) Ensure that KotlionBuilder workers use a clean directory for each compilation. (bazelbuild#298) Apply autoformatting to all files. (bazelbuild#302) Optional outputs (bazelbuild#291) Change plugins to use depsets, as opposed to lists. (bazelbuild#292) Add Corbin to the codeowners. (bazelbuild#293) Update Protobuf to 3.11.3 (bazelbuild#286) Remove tree artifacts (bazelbuild#287) Cleanup src tree (bazelbuild#288) Update README.md (bazelbuild#285) Filter non-kotlin code out of generated sources (bazelbuild#263) Update readme so the dev instructions highlight using a local clone (bazelbuild#283) Remove third_party checked in jars, and properly pull maven dependencies. (bazelbuild#279) Only propagate srcjar if it isn't the default empty jar added in ae70089 to fix bazelbuild/intellij#1616 (bazelbuild#276) Allow resources to be in a kotlin directory (bazelbuild#268)
jongerrish
added a commit
to jongerrish/rules_kotlin
that referenced
this pull request
Apr 16, 2020
remove the generation of unused tree artifacts from the compile step. Tree artifacts, (created by declare_directory) are only useful when an action produces an unknown number of outputs. It this case, this would only result in extra overhead of bundling the produced directories in archives with ever using them. Co-authored-by: Christian Edward Gruber <christianedwardgruber@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small optimization for kotlin compilation. May result in improvements for remote builds.
Depends on: /pull/288