Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove third_party checked in jars, and properly pull maven dependencies. #279

Merged
merged 7 commits into from
Feb 18, 2020

Conversation

restingbull
Copy link
Collaborator

Update the rules_kotlin dependencies to stop using the third_party directory.

This is a breaking change to the repository, as WORKSPACE pulling from the repository will need to add additional step to download the dependencies:

load("//kotlin:dependencies.bzl", "kt_download_local_dev_dependencies")
kt_download_local_dev_dependencies()

Corbin McNeely-Smith added 2 commits February 10, 2020 11:44
* Introduce maven_install for all maven third_party dependencies
* Collected all http_* downloads into downloads.bzl, and configuration in setup.bzl. Simplifies example setup.
* Remove checked in jars, fixed build references.
…he generated jvm_import rule. There is a strange interaction with jvm_import and java_test.data.

Issue: bazelbuild/issues/275
Issue: bazelbuild/issues/269
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
WORKSPACE Show resolved Hide resolved
master-builder Outdated Show resolved Hide resolved
src/main/protobuf/BUILD Show resolved Hide resolved
src/test/kotlin/io/bazel/kotlin/builder/BUILD Outdated Show resolved Hide resolved
kotlin/kotlin.bzl Outdated Show resolved Hide resolved
@cgruber cgruber merged commit df0c541 into bazelbuild:master Feb 18, 2020
@restingbull restingbull deleted the use-maven-deps branch February 18, 2020 22:50
restingbull pushed a commit to restingbull/rules_kotlin that referenced this pull request Feb 24, 2020
…ies. (bazelbuild#279)

* Convert all dependencies to the modern equivalents.

* Introduce maven_install for all maven third_party dependencies
* Collected all http_* downloads into downloads.bzl, and configuration in setup.bzl. Simplifies example setup.
* Remove checked in jars, fixed build references.

* Fix kapt test by referencing the underlying maven jav and not using the generated jvm_import rule. There is a strange interaction with jvm_import and java_test.data.

    Issue: bazelbuild/issues/275
    Issue: bazelbuild/issues/269

* Correct the examples to reference the dev dependencies properly.

* Correct the examples to reference the dev dependencies properly.

* Documentation fixes.

* Fix comment spelling and revert define_kt_toolchain removal. Whoops. We should have tests for that.

* fix spaces
cromwellian pushed a commit to cromwellian/rules_kotlin that referenced this pull request Mar 7, 2020
…ies. (bazelbuild#279)

* Convert all dependencies to the modern equivalents.

* Introduce maven_install for all maven third_party dependencies
* Collected all http_* downloads into downloads.bzl, and configuration in setup.bzl. Simplifies example setup.
* Remove checked in jars, fixed build references.

* Fix kapt test by referencing the underlying maven jav and not using the generated jvm_import rule. There is a strange interaction with jvm_import and java_test.data.

    Issue: bazelbuild/issues/275
    Issue: bazelbuild/issues/269

* Correct the examples to reference the dev dependencies properly.

* Correct the examples to reference the dev dependencies properly.

* Documentation fixes.

* Fix comment spelling and revert define_kt_toolchain removal. Whoops. We should have tests for that.

* fix spaces
cgruber added a commit to cgruber/rules_kotlin that referenced this pull request Apr 14, 2020
* upstream/master:
  Fix non-reproducible archives (bazelbuild#304)
  Adds a kt_plugin rule (bazelbuild#308)
  Ensure that KotlionBuilder workers use a clean directory for each compilation. (bazelbuild#298)
  Apply autoformatting to all files. (bazelbuild#302)
  Optional outputs (bazelbuild#291)
  Change plugins to use depsets, as opposed to lists. (bazelbuild#292)
  Add Corbin to the codeowners. (bazelbuild#293)
  Update Protobuf to 3.11.3 (bazelbuild#286)
  Remove tree artifacts (bazelbuild#287)
  Cleanup src tree (bazelbuild#288)
  Update README.md (bazelbuild#285)
  Filter non-kotlin code out of generated sources (bazelbuild#263)
  Update readme so the dev instructions highlight using a local clone (bazelbuild#283)
  Remove third_party checked in jars, and properly pull maven dependencies. (bazelbuild#279)
  Only propagate srcjar if it isn't the default empty jar added in ae70089 to fix bazelbuild/intellij#1616 (bazelbuild#276)
  Allow resources to be in a kotlin directory (bazelbuild#268)
jongerrish added a commit to jongerrish/rules_kotlin that referenced this pull request Apr 16, 2020
…ies. (bazelbuild#279)

* Convert all dependencies to the modern equivalents.

* Introduce maven_install for all maven third_party dependencies
* Collected all http_* downloads into downloads.bzl, and configuration in setup.bzl. Simplifies example setup.
* Remove checked in jars, fixed build references.

* Fix kapt test by referencing the underlying maven jav and not using the generated jvm_import rule. There is a strange interaction with jvm_import and java_test.data.

    Issue: bazelbuild/issues/275
    Issue: bazelbuild/issues/269

* Correct the examples to reference the dev dependencies properly.

* Correct the examples to reference the dev dependencies properly.

* Documentation fixes.

* Fix comment spelling and revert define_kt_toolchain removal. Whoops. We should have tests for that.

* fix spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants