CLion support for cc_library implementation deps #6919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeFrosch
changed the title
LeFrosch
force-pushed
the
implementation_deps
branch
from
7ffd69e to
ef30d1a
Compare
github-actions
bot
added
product: CLion
ujohnny
reviewed
Oct 21, 2024
| quote_includes = compilation_context.quote_includes.to_list() | ||
| system_includes = compilation_context.system_includes.to_list() | ||
|
|
||
| if hasattr(ctx.rule.attr, "implementation_deps"): |
There was a problem hiding this comment.
can't this information be obtained from CcInfo provider?
There was a problem hiding this comment.
I don't think there is a way since bazel treats impl deps context different from the main context. CcInfo only exposes the main context as far as I can tell.
LeFrosch
force-pushed
the
implementation_deps
branch
from
ef30d1a to
6db1fa5
Compare
# Conflicts: # .bazelrc # clwb/tests/integrationtests/com/google/idea/blaze/clwb/VirtualIncludesTest.java
LeFrosch
force-pushed
the
implementation_deps
branch
from
6db1fa5 to
b476b27
Compare
github-actions
bot
removed
the
awaiting-review
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion thread for this change
Issue number: #5149
Description of this change
Rebased PR #5220 and added an integration test for implementation_deps.