Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling in aspect for implementation_deps #5220

Conversation

sfc-gh-abalik
Copy link
Contributor

@sfc-gh-abalik sfc-gh-abalik commented Aug 8, 2023

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: #5149

Description of this change

Update the aspect to

  • Propagate along implementation_deps
  • Collect includes/defines from a target's implementation_deps

These changes are needed to enable intellisense, go to definition, etc in CLion for files that belong to targets using implementation_deps.

@github-actions github-actions bot added the awaiting-review Awaiting review from Bazel team on PRs label Aug 8, 2023
aspect/intellij_info_impl.bzl Outdated Show resolved Hide resolved
@sfc-gh-abalik sfc-gh-abalik force-pushed the abalik-implementation_deps-aspect-fix branch from a5a6dc4 to b9a247e Compare August 10, 2023 03:13
@mai93 mai93 assigned tpasternak and unassigned mai93 Aug 14, 2023
@sfc-gh-abalik
Copy link
Contributor Author

@tpasternak would you be able to take a look at this?

@tpasternak
Copy link
Contributor

I'm not sure if I understand the whole idea of implementation_deps correctly, but for me it looks like a bug inside bazel. The data from implementation_deps should already be available in compilation_context

cc @ujohnny

@tpasternak
Copy link
Contributor

bazelbuild/bazel#19663

@dieortin
Copy link

Is this expected to be merged? At this time implementation_deps is unusable when developing with CLion

@tpasternak
Copy link
Contributor

@ujohnny @LeFrosch as the Bazel team rejected to fix that on their side, I think we should accept the change. WDYT?

@LeFrosch
Copy link
Collaborator

@tpasternak I can check it on Friday

@sfc-gh-abalik
Copy link
Contributor Author

Closing since a similar fix was made in #6919.

@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: IntelliJ IntelliJ plugin
Projects
Development

Successfully merging this pull request may close these issues.

7 participants