Bazel plugin for Intellij sets wrong kotlin version

[CharlieCrisp]

I have recently upgraded to the these rules (commit ab2f9f79912a35af3c1a07849d6fb457c2bfc54b) and when trying to use Kotlin 1.3 in IntelliJ, I noticed the kotlin "Language version"/"API Version", gets set by the Bazel plugin to be 1.2 on every 'sync'.

• I'm definitely using 1.3. as bazel builds from the terminal compile 1.3 features.
• IntelliJ gives a quick-fix using alt-enter that removes the red squiggly lines, however this error comes back upon bazel sync.
• Setting the toolchain manually allows the "Language version"/"API Version" to remain at 1.3 but the error still comes upon syncs and the quick-fix works until the next sync.

[cgruber]

This is a place where we'll need to chat with the folks from bazelbuild/intellij or folks who dabble in all the areas. It's not clear to me what metadata the kotlin rules need to expose in order for the plugin to pick this up.

@jin, do you have any insights here?

[jin]

This sounds like an IJwBazel issue. Transferred to bazelbuild/intellij.

[jin]

Please provide your version information (IntelliJ Menu -> Bazel -> File an Issue on GitHub, and copy the version information here)

[CharlieCrisp]

Version information

IdeaUltimate: 2019.2.3
Platform: Mac OS X 10.14.6
Bazel plugin: 2019.10.01.1.1
Bazel: 0.28.1

Problem

language setting

Choosing the quick fix solves the problem until hitting the sync button when it reverts. Language version (as per the second screenshot) is always set to 1.3

[CharlieCrisp]

So I may have fixed this by adding kotlin to the additional_languages in the .bazelproject. Not sure why it has the observed behaviour without this though

[cgruber]

What I'm wondering (@jin, @brendandouglas) is whether there's metadata that ought to be given to the aspect, that identifies the kotlin language version (we have that data in the rules_kotlin toolchain). I just don't know where you need to get that info into the plugin, and if it's just something we need to add to the aspect?

[brendandouglas]

That is something we'd like to pick up for external rules. For internal kotlin rules, we get both the language version and SDK library jars from the toolchain target, and pass them through to the plugin (KotlinToolchainIdeInfo). Last I checked (~1-2 years ago) we couldn't do this for the external rules, but sounds like that info is available to aspects now?

…

On Fri, Dec 6, 2019 at 2:12 PM Christian Edward Gruber < ***@***.***> wrote: What I'm wondering ***@***.*** <https://github.com/jin>, @brendandouglas <https://github.com/brendandouglas>) is whether there's metadata that ought to be given to the aspect, that identifies the kotlin language version (we have that data in the rules_kotlin toolchain). I just don't know where you need to get that info into the plugin, and if it's just something we need to add to the aspect? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1274?email_source=notifications&email_token=AE3KDEPOBM2PP3KQVGYPR4TQXKPYJA5CNFSM4JBOYQ4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGFCDKY#issuecomment-562700715>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE3KDEKCCGBKZC2IRLKRLJLQXKPYJANCNFSM4JBOYQ4A> .

[szinn]

#1473

Submitted this PR to default the Kotlin version to be 1.3 which takes care of most issues. Getting the KotlinToolchainIdeInfo filled in is the long-term better way to go though if external rules can do it through aspects (I'll take a look)

[jasonwyatt]

This is an incredibly frustrating issue given 1.3 has been out for several months now, and 1.4 is coming up quickly.

It would be nice to have a field available in the project view file to specify which version to allow.

[szinn]

Submitted PR #1566 to pull the version information from the rules_kotlin build

[DrewKiino]

bump - can we get this fixed please?