Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up Kotlin version from rules_kotlin #1566

Closed
wants to merge 16 commits into from
Closed

Pick up Kotlin version from rules_kotlin #1566

wants to merge 16 commits into from

Conversation

szinn
Copy link

@szinn szinn commented Jan 15, 2020

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • [?] I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: 1274

Description of this change

This change gets the kotlin version from rules_kotlin (commit 242 - bazelbuild/rules_kotlin@a3d4d56) and updates the ide_info such that Kotlin 1.3 functionality can be accessed if compiled with Kotlin 1.3

@brendandouglas
Copy link
Contributor

Thanks, we can apply this upstream. It should go in aspect/intellij_info.bzl instead, as it's bazel-specific (doesn't apply to our internal build system, which has different kotlin rules)

@szinn
Copy link
Author

szinn commented Jan 16, 2020

@brendandouglas Does that mean you will apply the change or should I change the PR?

@szinn
Copy link
Author

szinn commented Jan 27, 2020

retest this please

@szinn
Copy link
Author

szinn commented Mar 21, 2020

@brendandouglas Any movement on this PR?

@cgruber
Copy link
Contributor

cgruber commented Mar 27, 2020

Please can we get some eyes on this (@jin maybe?) Someone? We're nearly at Kotlin 1.4, and we still have the IDE re-configured to be at 1.2 every time we sync. The kotlin rules are passing the information and this PR scoops that up and properly sets the language level. This is critical to a decent user experience.

@jin
Copy link
Member

jin commented Mar 27, 2020

@brendandouglas is this good for import? and could we use the internal copybara script to import this, or has that diverged or bit rotted?

@DrewKiino
Copy link

bump - can we get this landed?

@szinn
Copy link
Author

szinn commented Apr 5, 2020

Bump again @brendandouglas @jin

@szinn
Copy link
Author

szinn commented Apr 17, 2020

@jin
Copy link
Member

jin commented Apr 17, 2020

I've imported the PR. Please hold on for the internal review.

@ghost ghost closed this in fcfc098 Apr 20, 2020
@DrewKiino
Copy link

nice!!!

@cgruber
Copy link
Contributor

cgruber commented May 7, 2020

I'm so glad this is in. I'm having a heck of a time with coroutines. Thanks @jin !!

@szinn szinn deleted the fix-missing-external-libraries-computation branch June 18, 2020 11:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants