-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pick up Kotlin version from rules_kotlin #1566
Pick up Kotlin version from rules_kotlin #1566
Conversation
- correctly sets the Kotlin language version
…nal-libraries-computation
…nal-libraries-computation
…github.com/szinn/intellij into fix-missing-external-libraries-computation
…nal-libraries-computation
…nal-libraries-computation
…github.com/szinn/intellij into fix-missing-external-libraries-computation
Thanks, we can apply this upstream. It should go in aspect/intellij_info.bzl instead, as it's bazel-specific (doesn't apply to our internal build system, which has different kotlin rules) |
@brendandouglas Does that mean you will apply the change or should I change the PR? |
retest this please |
…nal-libraries-computation
…github.com/szinn/intellij into fix-missing-external-libraries-computation
…nal-libraries-computation
…nal-libraries-computation
…github.com/szinn/intellij into fix-missing-external-libraries-computation
@brendandouglas Any movement on this PR? |
Please can we get some eyes on this (@jin maybe?) Someone? We're nearly at Kotlin 1.4, and we still have the IDE re-configured to be at 1.2 every time we sync. The kotlin rules are passing the information and this PR scoops that up and properly sets the language level. This is critical to a decent user experience. |
@brendandouglas is this good for import? and could we use the internal copybara script to import this, or has that diverged or bit rotted? |
bump - can we get this landed? |
Bump again @brendandouglas @jin |
…nal-libraries-computation
I've imported the PR. Please hold on for the internal review. |
fcfc098
nice!!! |
I'm so glad this is in. I'm having a heck of a time with coroutines. Thanks @jin !! |
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number:
1274
Description of this change
This change gets the kotlin version from rules_kotlin (commit 242 - bazelbuild/rules_kotlin@a3d4d56) and updates the ide_info such that Kotlin 1.3 functionality can be accessed if compiled with Kotlin 1.3