bazelisk.go: add simple .bazeliskrc file support #127
Conversation
Replace `os.Getenv` with `getEnvOrConfig`, which falls back to parsing key=value pairs from a `.bazeliskrc` file in the workspace root. Environment variables take precedence. Aims to solve #119 as simply as possible.
|
fyi, @cheister |
|
@philwo, is there anything that the community can do to help push this one through? I think this PR has a lot of merit, and would reduce configuration burden on newcomers to bazelisk. |
|
@joeljeske Sorry, I've been super busy with finishing non-Bazelisk things that have to be done until end of this quarter - I'll get back to the issues and PRs here as soon as possible. Really looking forward to review / merge this and address any other open things. |
| continue | ||
| } | ||
| key := strings.TrimSpace(parts[0]) | ||
| if strings.HasPrefix(key, "#") { |
There was a problem hiding this comment.
Slightly more efficient if this check is the first line inside the loop
| } | ||
|
|
||
| // Parse .bazeliskrc in the workspace root, once, if it can be found. | ||
| fileConfigOnce.Do(func() { |
There was a problem hiding this comment.
Optional: for my taste a bit too long for an anonymous function
|
I talked with @fweikert, I'll just merge this now and we can polish later. 😊 |
Replace
os.GetenvwithgetEnvOrConfig, which falls back to parsingkey=value pairs from a
.bazeliskrcfile in the workspaceroot. Environment variables take precedence.
Aims to solve #119 as simply as possible.