Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a persisted way to configure BAZELISK_BASE_URL #119

Closed
joeljeske opened this issue Feb 11, 2020 · 1 comment
Closed

Support a persisted way to configure BAZELISK_BASE_URL #119

joeljeske opened this issue Feb 11, 2020 · 1 comment

Comments

@joeljeske
Copy link

I would like to specify the base url. at which to download bazel in a manner that is able to be managed by source control.

My use case is that I want to ensure that users of my project are directed to a site that would be available to them without needing to configure proxies in a corporate environment. (Related to #115)

It would seem like creating a .bazeliskrc or something could be useful for setting these the controls that are currently only configurable via env vars. I would not be opposed to leveraging a key-value system inside the .bazelversion but I'm not sure of the number of tools that leverage this file and that would be appropriate.

I imagine this file could also be used for the following in the future:

  • Setting SHAs per-platform to verify the downloads (in the case of non-floating versions)
  • Multiple fallback urls (similar to http_archive)
  • Persisting "The Company's" BAZELISK_GITHUB_TOKEN as to not require each dev to set it to avoid tripping rate limits
  • Override the default cache directory

What do you think of this approach?

philwo pushed a commit that referenced this issue Jul 2, 2020
Replace `os.Getenv` with `getEnvOrConfig`, which falls back to parsing
key=value pairs from a `.bazeliskrc` file in the workspace
root. Environment variables take precedence.

Aims to solve #119 as simply as possible.

Closes #127.
@joeljeske
Copy link
Author

Fixed in #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant