Pass execution info to xml generating spawn. Fixes #7794 #7796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change [1] splits test execution into two spawns. The first spawn runs the test and the second spawn generates the test.xml from the test.log file. This change makes it so that the test.xml-generating spawn also inherits the execution info from the test target. In particular, if a test target is tagged with "no-remote" then the test.xml-generating spawn will also be tagged. [1] bazelbuild@0858ae1
ulfjack
approved these changes
Mar 21, 2019
katre
pushed a commit
that referenced
this pull request
Mar 21, 2019
Change [1] splits test execution into two spawns. The first spawn runs the test and the second spawn generates the test.xml from the test.log file. This change makes it so that the test.xml-generating spawn also inherits the execution info from the test target. In particular, if a test target is tagged with "no-remote" then the test.xml-generating spawn will also be tagged. [1] 0858ae1 Closes #7796. PiperOrigin-RevId: 239608851
katre
pushed a commit
that referenced
this pull request
Mar 21, 2019
Change [1] splits test execution into two spawns. The first spawn runs the test and the second spawn generates the test.xml from the test.log file. This change makes it so that the test.xml-generating spawn also inherits the execution info from the test target. In particular, if a test target is tagged with "no-remote" then the test.xml-generating spawn will also be tagged. [1] 0858ae1 Closes #7796. PiperOrigin-RevId: 239608851
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change [1] splits test execution into two spawns. The first spawn runs
the test and the second spawn generates the test.xml from the test.log
file. This change makes it so that the test.xml-generating spawn also
inherits the execution info from the test target. In particular, if a
test target is tagged with "no-remote" then the test.xml-generating
spawn will also be tagged.
[1] 0858ae1