pass platform and execution requirements to xml generating spawn #7794
Labels
P1
I'll work on this now. (Assignee required)
team-Remote-Exec
Issues and PRs for the Execution (Remote) team
Comments
buchgr
added
P1
|
Does this issue only happen when |
|
no it's independent of the test.log size. |
|
The workaround for this issue is to use |
buchgr
added a commit
to buchgr/bazel
that referenced
this issue
Mar 21, 2019
Change [1] splits test execution into two spawns. The first spawn runs the test and the second spawn generates the test.xml from the test.log file. This change makes it so that the test.xml-generating spawn also inherits the execution info from the test target. In particular, if a test target is tagged with "no-remote" then the test.xml-generating spawn will also be tagged. [1] bazelbuild@0858ae1
katre
pushed a commit
that referenced
this issue
Mar 21, 2019
Change [1] splits test execution into two spawns. The first spawn runs the test and the second spawn generates the test.xml from the test.log file. This change makes it so that the test.xml-generating spawn also inherits the execution info from the test target. In particular, if a test target is tagged with "no-remote" then the test.xml-generating spawn will also be tagged. [1] 0858ae1 Closes #7796. PiperOrigin-RevId: 239608851
katre
pushed a commit
that referenced
this issue
Mar 21, 2019
Change [1] splits test execution into two spawns. The first spawn runs the test and the second spawn generates the test.xml from the test.log file. This change makes it so that the test.xml-generating spawn also inherits the execution info from the test target. In particular, if a test target is tagged with "no-remote" then the test.xml-generating spawn will also be tagged. [1] 0858ae1 Closes #7796. PiperOrigin-RevId: 239608851
bazel-io
pushed a commit
that referenced
this issue
Mar 26, 2019
Baseline: 235e76b Cherry picks: + badd82e: Automated rollback of commit 1b4c37c. + 33e5719: Fix the Python version select() mechanism to handle PY3-as-default + 56366ee: Set non-empty values for msvc_env_* when VC not installed + 22b3fbf: Windows, test wrapper: fix broken integration test + f14d447: Add whitelist file for starlark transitions + d99bc47: Update BUILD + 3529ad7: Rename tools/function_transition_whitelist/BUILD to tools/whitelists/function_transition_whitelist/BUILD + de0612a: Update bazel_toolchains to latest release and add toolchain config target for BuildKite CI (rbe_ubuntu1604) + 3e660ad: Automated rollback of commit 0877340. + 314cf1f: Pass -undefined dynamic_lookup to dynamic library linking actions on Mac + fc586a8: Move cc_flags target into @bazel_tools//tools/cpp. + ea1703b: C++: Fix crash reported in #7721 + 803801d: Pass execution info to xml generating spawn. Fixes #7794 Incompatible changes: - Added --incompatible_py3_is_default to test switching the default Python version to PY3 for py_binary/py_test targets that do not specify a version. See #7359. - //tools/cmd_line_differ has been renamed to //tools/aquery_differ & can now compare (in addition to command lines) inputs of actions given 2 aquery results. - java_(mutable_|)proto_library: removed strict_deps attribute. - The flag --incompatible_list_based_execution_strategy_selection was added and is used to ease the migration to the new style of specifying execution strategy selection and fallback behavior. The documentation for this flag is here: #7480 - Added --incompatible_py2_outputs_are_suffixed, for switching the bazel-bin symlink to point to Python 3 outputs instead of Python 2 outputs. See [#7593](#7593). New features: - Make actions.args() object chainable. - Added --incompatible_windows_style_arg_escaping flag: enables correct subprocess argument escaping on Windows. (No-op on other platforms.) - Added --incompatible_windows_escape_jvm_flags flag: enables correct java_binary.jvm_flags and java_test.jvm_flags tokenization and escaping on Windows. (No-op on other platforms.) Important changes: - Allow running aquery against the current state of Skyframe - Added support for the "navigation" resource directory to Android resource processing in Bazel. This is used by the Navigation Architecture Component. - --incompatible_disable_runtimes_filegroups was flipped (#6942) - Incompatible flag `--incompatible_linkopts_in_user_link_flags` has been flipped (#6826) - Incompatible flag `--incompatible_dont_emit_static_libgcc` has been flipped (#6825) - --incompatible_disallow_filetype is enabled by default. - Fixed issue where exceptions and stacktraces were silently swallowed in the Android resource processing pipeline. - `--incompatible_disable_expand_if_all_available_in_flag_set` has been flipped (#7008) - --incompatible_disallow_dict_plus is enabled by default - Adds --incompatible_disable_objc_library_resources to disable resource attributes in objc_library. Please migrate these attributes to `data` instead. - --incompatible_disallow_old_style_args_add is enabled by default. - Using the `native` module in BUILD files is deprecated. It will be forbidden with --incompatible_disallow_native_in_build_file. - (Python rules) PyRuntimeInfo is exposed to Starlark, making it possible for Starlark rules to depend on or imitate `py_runtime`. The `files` attribute of `py_runtime` is no longer mandatory. - incompatible_use_toolchain_providers_in_java_common: pass JavaToolchainInfo and JavaRuntimeInfo providers to java_common APIs instead of configured targetshttps://github.com//issues/7186. - is_using_fission crosstool variable is now exposed in all compile actions when fission is active (it used to be exposed only for linking actions). - incompatible_use_toolchain_providers_in_java_common: pass JavaToolchainInfo and JavaRuntimeInfo providers to java_common APIs instead of configured targetshttps://github.com//issues/7186. - `py_runtime` gains a `python_version` attribute for specifying whether it represents a Python 2 or 3 interpreter. - `--incompatible_java_coverage` is enabled by default. - Starlark rules can safely declare attributes named "licenses" - When using --incompatible_list_based_execution_strategy_selection, Bazel will use remote execution by default (if you specify --remote_executor), otherwise persistent workers (if the action supports it), otherwise sandboxed local execution (if the action and platform supports it) and at last unsandboxed local execution. The flags --spawn_strategy and --strategy continue to work as before - this only sets new defaults for the case where you don't specify these flags. - Set default value of --incompatible_remap_main_repo to true. - Set default value of --incompatible_remap_main_repo to true. This release contains contributions from many people at Google, as well as Andrew Suffield, Brandon Lico, Chris Eason, Clint Harrison, Ed Schouten, Garrett Hopper, George Gensure, Greg, John Millikin, Julie, Keith Smiley, Laurent Le Brun, Ryan Beasley, Shmuel H, Travis Cline, Vladimir Chebotarev.
katre
pushed a commit
that referenced
this issue
Mar 29, 2019
Baseline: 235e76b Cherry picks: + badd82e: Automated rollback of commit 1b4c37c. + 33e5719: Fix the Python version select() mechanism to handle PY3-as-default + 56366ee: Set non-empty values for msvc_env_* when VC not installed + 22b3fbf: Windows, test wrapper: fix broken integration test + f14d447: Add whitelist file for starlark transitions + d99bc47: Update BUILD + 3529ad7: Rename tools/function_transition_whitelist/BUILD to tools/whitelists/function_transition_whitelist/BUILD + de0612a: Update bazel_toolchains to latest release and add toolchain config target for BuildKite CI (rbe_ubuntu1604) + 3e660ad: Automated rollback of commit 0877340. + 314cf1f: Pass -undefined dynamic_lookup to dynamic library linking actions on Mac + fc586a8: Move cc_flags target into @bazel_tools//tools/cpp. + ea1703b: C++: Fix crash reported in #7721 + 803801d: Pass execution info to xml generating spawn. Fixes #7794 Incompatible changes: - Added --incompatible_py3_is_default to test switching the default Python version to PY3 for py_binary/py_test targets that do not specify a version. See #7359. - //tools/cmd_line_differ has been renamed to //tools/aquery_differ & can now compare (in addition to command lines) inputs of actions given 2 aquery results. - java_(mutable_|)proto_library: removed strict_deps attribute. - The flag --incompatible_list_based_execution_strategy_selection was added and is used to ease the migration to the new style of specifying execution strategy selection and fallback behavior. The documentation for this flag is here: #7480 - Added --incompatible_py2_outputs_are_suffixed, for switching the bazel-bin symlink to point to Python 3 outputs instead of Python 2 outputs. See [#7593](#7593). New features: - Make actions.args() object chainable. - Added --incompatible_windows_style_arg_escaping flag: enables correct subprocess argument escaping on Windows. (No-op on other platforms.) - Added --incompatible_windows_escape_jvm_flags flag: enables correct java_binary.jvm_flags and java_test.jvm_flags tokenization and escaping on Windows. (No-op on other platforms.) Important changes: - Allow running aquery against the current state of Skyframe - Added support for the "navigation" resource directory to Android resource processing in Bazel. This is used by the Navigation Architecture Component. - --incompatible_disable_runtimes_filegroups was flipped (#6942) - Incompatible flag `--incompatible_linkopts_in_user_link_flags` has been flipped (#6826) - Incompatible flag `--incompatible_dont_emit_static_libgcc` has been flipped (#6825) - --incompatible_disallow_filetype is enabled by default. - Fixed issue where exceptions and stacktraces were silently swallowed in the Android resource processing pipeline. - `--incompatible_disable_expand_if_all_available_in_flag_set` has been flipped (#7008) - --incompatible_disallow_dict_plus is enabled by default - Adds --incompatible_disable_objc_library_resources to disable resource attributes in objc_library. Please migrate these attributes to `data` instead. - --incompatible_disallow_old_style_args_add is enabled by default. - Using the `native` module in BUILD files is deprecated. It will be forbidden with --incompatible_disallow_native_in_build_file. - (Python rules) PyRuntimeInfo is exposed to Starlark, making it possible for Starlark rules to depend on or imitate `py_runtime`. The `files` attribute of `py_runtime` is no longer mandatory. - incompatible_use_toolchain_providers_in_java_common: pass JavaToolchainInfo and JavaRuntimeInfo providers to java_common APIs instead of configured targetshttps://github.com//issues/7186. - is_using_fission crosstool variable is now exposed in all compile actions when fission is active (it used to be exposed only for linking actions). - incompatible_use_toolchain_providers_in_java_common: pass JavaToolchainInfo and JavaRuntimeInfo providers to java_common APIs instead of configured targetshttps://github.com//issues/7186. - `py_runtime` gains a `python_version` attribute for specifying whether it represents a Python 2 or 3 interpreter. - `--incompatible_java_coverage` is enabled by default. - Starlark rules can safely declare attributes named "licenses" - When using --incompatible_list_based_execution_strategy_selection, Bazel will use remote execution by default (if you specify --remote_executor), otherwise persistent workers (if the action supports it), otherwise sandboxed local execution (if the action and platform supports it) and at last unsandboxed local execution. The flags --spawn_strategy and --strategy continue to work as before - this only sets new defaults for the case where you don't specify these flags. - Set default value of --incompatible_remap_main_repo to true. - Set default value of --incompatible_remap_main_repo to true. This release contains contributions from many people at Google, as well as Andrew Suffield, Brandon Lico, Chris Eason, Clint Harrison, Ed Schouten, Garrett Hopper, George Gensure, Greg, John Millikin, Julie, Keith Smiley, Laurent Le Brun, Ryan Beasley, Shmuel H, Travis Cline, Vladimir Chebotarev.
bazel-io
pushed a commit
that referenced
this issue
Apr 2, 2019
Baseline: 235e76b Cherry picks: + badd82e: Automated rollback of commit 1b4c37c. + 33e5719: Fix the Python version select() mechanism to handle PY3-as-default + 56366ee: Set non-empty values for msvc_env_* when VC not installed + 22b3fbf: Windows, test wrapper: fix broken integration test + f14d447: Add whitelist file for starlark transitions + d99bc47: Update BUILD + 3529ad7: Rename tools/function_transition_whitelist/BUILD to tools/whitelists/function_transition_whitelist/BUILD + de0612a: Update bazel_toolchains to latest release and add toolchain config target for BuildKite CI (rbe_ubuntu1604) + 3e660ad: Automated rollback of commit 0877340. + 314cf1f: Pass -undefined dynamic_lookup to dynamic library linking actions on Mac + fc586a8: Move cc_flags target into @bazel_tools//tools/cpp. + ea1703b: C++: Fix crash reported in #7721 + 803801d: Pass execution info to xml generating spawn. Fixes #7794 + f092ec3: Release 0.24.0 (2019-03-26) + c56c489: Wrap StatusRuntimeExceptions from GrpcRemoteCache Baseline: f092ec3 Cherrypicks: + c56c489: Wrap StatusRuntimeExceptions from GrpcRemoteCache
cgruber
pushed a commit
to cgruber/bazel
that referenced
this issue
Apr 30, 2019
Baseline: 235e76b Cherry picks: + badd82e: Automated rollback of commit 1b4c37c. + 33e5719: Fix the Python version select() mechanism to handle PY3-as-default + 56366ee: Set non-empty values for msvc_env_* when VC not installed + 22b3fbf: Windows, test wrapper: fix broken integration test + f14d447: Add whitelist file for starlark transitions + d99bc47: Update BUILD + 3529ad7: Rename tools/function_transition_whitelist/BUILD to tools/whitelists/function_transition_whitelist/BUILD + de0612a: Update bazel_toolchains to latest release and add toolchain config target for BuildKite CI (rbe_ubuntu1604) + 3e660ad: Automated rollback of commit 0877340. + 314cf1f: Pass -undefined dynamic_lookup to dynamic library linking actions on Mac + fc586a8: Move cc_flags target into @bazel_tools//tools/cpp. + ea1703b: C++: Fix crash reported in bazelbuild#7721 + 803801d: Pass execution info to xml generating spawn. Fixes bazelbuild#7794 + f092ec3: Release 0.24.0 (2019-03-26) + c56c489: Wrap StatusRuntimeExceptions from GrpcRemoteCache Baseline: f092ec3 Cherrypicks: + c56c489: Wrap StatusRuntimeExceptions from GrpcRemoteCache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The fix for #4608 splits a test action into two spawns. The first spawn runs the actual test and the second spawn declares the
test.logas an input and produces a test.xml file.We found an issue where a
sh_testtarget was marked asno-remotebut the test.xml-generating spawn would not get this tag passed along and would thus run remotely.The proposed fix is to pass along the execution requirements and platform of the test spawn to the test.xml-generating spawn.
The text was updated successfully, but these errors were encountered: