Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests on macOS #21381

Closed
wants to merge 10 commits into from
Closed

Conversation

meteorcloudy
Copy link
Member

@meteorcloudy meteorcloudy commented Feb 16, 2024

  • Add "--test_tag_filters=-no_macos" for macOS to filter out tests that are not suppose to run on Mac, just like the no_windows tag.
  • Fixed PatchApiBlackBoxTest and GitRepositoryBlackBoxTest on newer macOS versions.
  • Enable android tests that are not passing on macOS.
  • Enable previously disabled tests on arm64 macOS platform, disable slow tests on Intel macOS platform since they are often the bottleneck.

@meteorcloudy meteorcloudy marked this pull request as draft February 16, 2024 16:36
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Feb 16, 2024
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Feb 21, 2024
@Wyverald
Copy link
Member

@bazel-io fork 7.1.0

@iancha1992 iancha1992 requested review from iancha1992 and removed request for iancha1992 February 21, 2024 16:21
meteorcloudy added a commit to meteorcloudy/bazel that referenced this pull request Feb 21, 2024
- Add `--test_tag_filters=-no_macos` for macOS to filter out tests that are not suppose to run on Mac, just like the `no_windows` tag.
- Fixed PatchApiBlackBoxTest and GitRepositoryBlackBoxTest on newer macOS versions.
- Enable previously disabled tests on arm64 macOS platform in presubmit
- Disable slow tests on Intel macOS platform in presubmit since they are often the bottleneck.

Tests fixed:

- Fixes bazelbuild#16525
- Fixes bazelbuild#17447
- Fixes bazelbuild#17411
- Related: bazelbuild#18776 (fixed on macos_arm64)

Closes bazelbuild#21381.

PiperOrigin-RevId: 608993052
Change-Id: I03bdf954c358bb736a866ce3a02f6dac4473e47e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants