Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

//src/test/java/com/google/devtools/build/lib/blackbox/tests/workspace:PatchApiBlackBoxTest started failing pre- and post-submit #17411

Closed
fweikert opened this issue Feb 3, 2023 · 1 comment
Labels
macos-infra-update P2 We'll consider working on this in future. (Assignee optional) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug

Comments

@fweikert
Copy link
Member

fweikert commented Feb 3, 2023

Description of the bug:

On Intel Macs:
//src/test/java/com/google/devtools/build/lib/blackbox/tests/workspace:PatchApiBlackBoxTest from https://buildkite.com/bazel/google-bazel-presubmit/builds/63133#01861789-3330-4511-bb43-08a2ed784ae1

ERROR: Error applying patch @//:remove-dragons.patch: patching file foo.sh 1 out of 1 hunks failed--saving rejects to foo.sh.rej

Might be related to the MacOS update.

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

No response

Which operating system are you running Bazel on?

No response

What is the output of bazel info release?

No response

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

copybara-service bot pushed a commit that referenced this issue Feb 3, 2023
…ates.

Related to #17410 and #17411.

PiperOrigin-RevId: 506903607
Change-Id: Ic88de4caea5c14336774e53a9063a6beb260d515
coeuvre pushed a commit to coeuvre/bazel that referenced this issue Feb 6, 2023
…ates.

Related to bazelbuild#17410 and bazelbuild#17411.

PiperOrigin-RevId: 506903607
Change-Id: Ic88de4caea5c14336774e53a9063a6beb260d515
coeuvre pushed a commit to coeuvre/bazel that referenced this issue Feb 6, 2023
…ates.

Related to bazelbuild#17410 and bazelbuild#17411.

PiperOrigin-RevId: 506903607
Change-Id: Ic88de4caea5c14336774e53a9063a6beb260d515
ShreeM01 pushed a commit that referenced this issue Feb 6, 2023
* Bazel CI: Disable tests that are failing due to infra upgrades.

This change should unblock both pre- and post-submit.

Related to #16526, #17407, #17408 and #17409.

PiperOrigin-RevId: 506882975
Change-Id: If704c398546265eb22d58906eb28363b30ac00a2

* Bazel CI: Disable more tests that are likely failing due to infra updates.

Related to #17410 and #17411.

PiperOrigin-RevId: 506903607
Change-Id: Ic88de4caea5c14336774e53a9063a6beb260d515

* Disable python_version_test

---------

Co-authored-by: Googler <fwe@google.com>
@sgowroji sgowroji added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Feb 7, 2023
@fweikert
Copy link
Member Author

fweikert commented Feb 8, 2023

Looks like #16550

hvadehra pushed a commit that referenced this issue Feb 14, 2023
…ates.

Related to #17410 and #17411.

PiperOrigin-RevId: 506903607
Change-Id: Ic88de4caea5c14336774e53a9063a6beb260d515
@meteorcloudy meteorcloudy added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. P2 We'll consider working on this in future. (Assignee optional) and removed team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website untriaged labels Mar 28, 2023
meteorcloudy added a commit to meteorcloudy/bazel that referenced this issue Feb 21, 2024
- Add `--test_tag_filters=-no_macos` for macOS to filter out tests that are not suppose to run on Mac, just like the `no_windows` tag.
- Fixed PatchApiBlackBoxTest and GitRepositoryBlackBoxTest on newer macOS versions.
- Enable previously disabled tests on arm64 macOS platform in presubmit
- Disable slow tests on Intel macOS platform in presubmit since they are often the bottleneck.

Tests fixed:

- Fixes bazelbuild#16525
- Fixes bazelbuild#17447
- Fixes bazelbuild#17411
- Related: bazelbuild#18776 (fixed on macos_arm64)

Closes bazelbuild#21381.

PiperOrigin-RevId: 608993052
Change-Id: I03bdf954c358bb736a866ce3a02f6dac4473e47e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macos-infra-update P2 We'll consider working on this in future. (Assignee optional) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug
Projects
None yet
Development

No branches or pull requests

4 participants