[6.1.0]Dont query remote cache but always use bytestream protocol #17291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `--experimental_remote_build_event_upload=minimal`, instead of querying remote cache to decide whether convert local path of a file to `bytestream://`, it now always use `bytestream://` for BEP referenced files. Closes #16999. Closes #17025. PiperOrigin-RevId: 502351401 Change-Id: Ic858367ffaf3c2a2c20db88ada85fbbe1d93aae8
|
Probably want a review from @coeuvre? |
Added. Thanks! |
coeuvre
requested changes
Jan 23, 2023
| expect_bes_file_uploaded command.profile.gz | ||
| } | ||
|
|
||
| function test_upload_minimal_upload_buildlogs() { |
There was a problem hiding this comment.
This test case failed because the release branch is missing #17110. Please cherry-pick that and rebase this PR.
There was a problem hiding this comment.
The test is now redundant (check test_upload_minimal_upload_buildlogs below). Please remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
--experimental_remote_build_event_upload=minimal, instead of querying remote cache to decide whether convert local path of a file tobytestream://, it now always usebytestream://for BEP referenced files.Closes #16999.
Closes #17025.
PiperOrigin-RevId: 502351401
Change-Id: Ic858367ffaf3c2a2c20db88ada85fbbe1d93aae8