Upload all logs in BEP even with minimal upload #17110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgowroji
added
team-Remote-Exec
coeuvre
requested changes
Jan 4, 2023
There was a problem hiding this comment.
Do we always want to upload action logs or only upload when they failed?
Please add a test case for this similar to test_upload_minimal_upload_testlogs.
coeuvre
added
awaiting-user-response
When using --experimental_remote_build_event_upload=minimal, build action logs won't get uploaded. These logs are still very useful as when a build action fails, one would need to inspect them to figure out what has gone wrong. Forcing uploading stdout and stderr with this change.
|
Seems that at least currently the build event file won't reference the build logs unless the action had failed so the logs will only be uploaded for failing actions. |
coeuvre
approved these changes
Jan 5, 2023
coeuvre
added
awaiting-PR-merge
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
sgowroji
removed
the
awaiting-PR-merge
|
@bazel-io fork 6.1.0 |
bazel-io
removed
the
potential release blocker
ShreeM01
added a commit
that referenced
this pull request
Jan 24, 2023
When using --experimental_remote_build_event_upload=minimal, build action logs won't get uploaded. These logs are still very useful as when a build action fails, one would need to inspect them to figure out what has gone wrong. Forcing uploading stdout and stderr with this change. Closes #17110. PiperOrigin-RevId: 500723770 Change-Id: I5e2edb6356b55549cd160379273af9a1580945d3 Co-authored-by: Emil Kattainen <emilkattainen@gmail.com>
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
When using --experimental_remote_build_event_upload=minimal, build action logs won't get uploaded. These logs are still very useful as when a build action fails, one would need to inspect them to figure out what has gone wrong. Forcing uploading stdout and stderr with this change. Closes #17110. PiperOrigin-RevId: 500723770 Change-Id: I5e2edb6356b55549cd160379273af9a1580945d3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using --experimental_remote_build_event_upload=minimal, build action logs won't get uploaded. These logs are still very useful as when a build action fails, one would need to inspect them to figure out what has gone wrong. Forcing uploading stdout and stderr with this change.